Re: GNOME CVS: gnome-panel cneumair



Hi Christian,
	Another query - did Anders approve the changes you've
been making to desktop_gnome_interface.schemas?

	The changes have been s/menus-have-icons/menus_have_icons/
etc. Is this not breaking backward compatibility ?

Cheers,
Mark.

On Sun, 2002-12-08 at 10:18, Mark McLoughlin wrote:
> Hi Christian,
> 	Committing unapproved patches to a module without
> even letting the maintainer know is unacceptable. I've
> reverted the commit.
> 
> 	You may have felt this was a cosmetic change, but
> what you failed to realise is that this breaks compatibility
> with existing panel configurations. This is why we have a
> policy of requiring patches to be reviewed.
> 
> Good Luck,
> Mark.
> 
> On Sat, 2002-12-07 at 08:09, Gnome CVS User wrote:
> > CVSROOT:	/cvs/gnome
> > Module name:	gnome-panel
> > Changes by:	cneumair	02/12/06 14:09:48
> > 
> > Modified files:
> > 	gnome-panel    : ChangeLog menu.c panel-config-global.c 
> > 	                 panel-config-global.h 
> > 	                 panel-global-config.schemas.in panel.c 
> > 
> > Log message:
> > tooltips_enabled => enable_tooltips
> > 
> > URL : http://cvs.gnome.org/bonsai/cvsquery.cgi?module=gnome-panel&branch=&branchtype=match&dir=gnome-panel&file=&filetype=match&who=cneumair&whotype=match&sortby=Date&hours=&date=explicit&mindate=2002-12-06%2014:08&maxdate=2002-12-06%2014:10&cvsroot=/cvs/gnome
> > 
> > _______________________________________________
> > cvs-commits-list mailing list
> > cvs-commits-list gnome org
> > http://mail.gnome.org/mailman/listinfo/cvs-commits-list
> 
> _______________________________________________
> gnome-hackers mailing list
> gnome-hackers gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-hackers




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]