Re: [Evolution-hackers] Streamlining e-text.c & e-cell-text.c

["Mayank Jain" <makuchaku gmail com>]

I've tried making the new implementation of layout_with_preedit
(widgets/table/e-cell-text.c)

The new code - http://makuchaku.pastebin.ca/84013
Old code - http://makuchaku.pastebin.ca/84015

It builds fine & works as expected (i did a brief testing).

I would request the calendar developers to kindly review the code & comment.

Thanks,
Makuchaku

On 7/10/06, Mayank Jain <makuchaku gmail com> wrote:
> Hi,
>
> I was looking at Evolution's code, when I saw that
> insert_preedit_text() in e-text.c (widgets/text/e-text.c) and
> layout_with_preedit in e-cell-text.c (widgets/table/e-cell-text.c) so
> almost the same thing : fetch the preedit string, add it to the
> current cursor location & update the layout.
>
> But they both do the same thing, but do it differently. Was this on
> some purpose or that the implementations gradually changed over a
> period of time?
>
> IMHO, they can be programmed in the same way (though their in/out
> params can be what they are). This will aid bugfixing.
>
> Open to comments...
>
> Makuchaku
> http://makuchaku.info