[Evolution-hackers] camel_store_get_folder_info suckage



ok, so I was right about the mbox code expecting NULL. but this may very
well have been my fault. anyways, that is now fixed in CVS along with
changes to set the fi->flags with CAMEL_FOLDER_CHILDREN,
CAMEL_FOLDER_NOSELECT, and CAMEL_FOLDER_NOINFERIORS and the like.

now for the new problem:

if you call get_folder_info without the RECURSIVE flag, you only get a
singleton fi returned to you. I guess this makes sense. (note, however,
that imap will return one level of subdirs as well - altho they will be
placed in fi->sibling rather than fi->child which is rather wrong).

so... the only way to get a list of subfolders of an mbox folder is to
request RECURSIVE. However, this scans more than just a single level
which is not what I want.

the way the IMAP spec deals with this, is by providing 2 modes of
recursive: % (1 level) and * (everything)

what do you think of having a
CAMEL_STORE_FOLDER_INFO_RECURSIVE_ONE_LEVEL type flag?


while on the subject of get_folder_info... the interface sucks. There
are several reasons it sucks, but the ones I'm thinking of right now is
that it doesn't allow for any sort of globbing and it is inconsistant
with the other camel-store methods in that the other methods take a path
while get_folder_info takes a full_name.

probably too late to change this interface tho. :-(

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]