Re: nautilus vs. gnome-settings-daemon "race"

[jacob berkman <jacob ximian com>]

On Wed, 2002-07-17 at 11:24, jacob berkman wrote:
> On Tue, 2002-07-16 at 19:10, Mark McLoughlin wrote:
> > Hi Jacob,
> > 
> > On 16 Jul 2002, jacob berkman wrote:
> > 
> > > On Tue, 2002-07-16 at 01:57, Mark McLoughlin wrote:
> > > > Hi Jacob,
> > > >
> > > > On 15 Jul 2002, jacob berkman wrote:
> > > >
> > > > > On Fri, 2002-07-12 at 14:54, jacob berkman wrote:
> > > > > > gnome-settings-daemon currently checks to see if nautilus is running,
> > > > > > and if so won't draw the background image.
> > > > > >
> > > > > > gnome-session starts gnome-settings-daemon before nautilus, so nautilus
> > > > > > isn't running when gnome-settings-daemon goes to draw the background.
> > > > > > this causes the background to get drawn twice, which slows down login a
> > > > > > bit.
> >
> > 	Well sure, but not this way - gnome-session should not be
> > special casing clients. I think the simplest solution should be that
> > g-s-d does not draw the background unless specifically enabled. I
> > *think* this is what /desktop/gnome/background/draw_background is
> > for ? If so, why not just have this off by default, and if some
> > decides to turn nautilus drawing the backround off, then they turn this
> > on ..

oh, i totally misread this.  i think just using the nautilus key will
work fine....

> ok, so it's possible for that key to be set but for nautilus to not be
> desired by the user.
> 
> so i think to myself, "is that going to happen much?" and then i think
> of people whining that nautilus is slow/etc. and the answer is, "just
> uncheck that toggle and close your nautilus windows..."
> 
> and then just checking the key works just fine...

btw here's a patch which should do this.  it's the nicest of all of them
so far ;)

 - jacob

Index: gnome-settings-background.c
===================================================================
RCS file: /cvs/gnome/gnome-control-center/gnome-settings-daemon/gnome-settings-background.c,v
retrieving revision 1.5
diff -u -r1.5 gnome-settings-background.c
--- gnome-settings-background.c	14 Jan 2002 16:46:48 -0000	1.5
+++ gnome-settings-background.c	17 Jul 2002 15:01:49 -0000
@@ -60,5 +60,16 @@
 void
 gnome_settings_background_load (GConfClient *client)
 {
+	/* If this is set, nautilus will draw the background and is
+	 * almost definitely in our session.  however, it may not be
+	 * running yet (so is_nautilus_running() will fail).  so, on
+	 * startup, just don't do anything if this key is set so we
+	 * don't waste time setting the background only to have
+	 * nautilus overwrite it.
+	 */
+
+	if (gconf_client_get_bool (client, "/apps/nautilus/preferences/show_desktop", NULL))
+		return;
+
 	bg_applier_apply_prefs (bg_applier, prefs);
 }