Re: Coredump of 1.4.3 on Solaris 8 SPARC with proposed fixes

[Eliseev Vladimir <evlad cge ru>]

ξΑ 2003.04.10 18:18 Albrecht Dre? ΞΑΠΙΣΑΜ:
> Am 10.04.03 17:51 schrieb(en) Eliseev Vladimir:
>> In proposed fixes subj=0x0 is replaced by subj="".
> 
> Hmmm, I would prefer to return _("(no subject)") in this case instead 
> of the empty string. Opinions?

OK, at least it will not cause SEGV :-)

>> I'm not using Balsa 2.x.x but the same problem may take place in it 
>> too.
> 
> If it happens when building the dialog, then there are *lots* more in 
> connection with the gpg stuff. As they always use the routine from 
> message.c, it's also fixed with your patch. Good work! Well, mostly 
> at least:
> 
>> --- 1031,1039 ----
>>           g_return_val_if_fail(CLIENT_CONTEXT_OPEN(msg->mailbox), 
>> NULL);
>>   	/* g_print("Returning libmutt's pointer\n"); */
>>   	return msg->header->env->subject;
>> !     } else if(NULL == msg->subj)
>> ! 	return "";
>> !     else
>>   	return msg->subj;
>>   }
> 
> This doesn't catch a NULL msg->header->env->subject (or is this 
> impossible?). So I would propose

I had never seen a Balsa coredump in this case, but this additional 
check is reasonable.

Regards,
                     Eliseev Vladimir