Patch for i18n




Hello,

Balsa does core dump when the newuser end the first setup
under multibyte environment.

When I translate "Trash" in *.po, the ~/balsarc will be such:

"Trash(translated)" = { Type=...; Name="Trash(translated)"; ...}

and it makes core dump.
So It should be:

"Trash(un-translated)" = { Type=...; Name="Trash(translated)"; ...}

It's not the only case with "Trash", but also with "Inbox", etc.
I attach the patch for libinit_balsa/balsa-druid-page-directory.gob.

This is an easy and small fix for all what should be done for the
real i18n mailing with balsa. So could you accept this patch and let
me discuss here more?

Thank you.

--------------
Yukihiro Nakai

cvs server: Diffing .
Index: balsa-druid-page-directory.gob
===================================================================
RCS file: /cvs/gnome/balsa/libinit_balsa/balsa-druid-page-directory.gob,v
retrieving revision 1.4
diff -u -r1.4 balsa-druid-page-directory.gob
--- balsa-druid-page-directory.gob	1999/12/30 21:14:15	1.4
+++ balsa-druid-page-directory.gob	2000/02/08 06:07:13
@@ -89,7 +89,7 @@
 
 	mt = mailbox_valid( dup );
 	box = BALSA_MAILBOX( mailbox_new( mt ) );
-	box->name = g_strdup( prettyname );
+	box->name = g_strdup( gettext(prettyname) );
 	(MAILBOX_LOCAL( box ))->path = dup;
 	config_mailbox_add( box, (char *) prettyname );
 	add_mailboxes_for_checking( box );
@@ -240,15 +240,15 @@
 		BalsaDruidPageDirectory *self = BALSA_DRUID_PAGE_DIRECTORY( _self );	
 
 		unconditional_mailbox( gtk_entry_get_text( GTK_ENTRY( self->_priv->inbox ) ),
-			_("Inbox"), &error );
+			"Inbox", &error );
 		unconditional_mailbox( gtk_entry_get_text( GTK_ENTRY( self->_priv->outbox ) ),
-			_("Outbox"), &error );
+			"Outbox", &error );
 		unconditional_mailbox( gtk_entry_get_text( GTK_ENTRY( self->_priv->sentbox ) ),
-			_("Sentbox"), &error );
+			"Sentbox", &error );
 		unconditional_mailbox( gtk_entry_get_text( GTK_ENTRY( self->_priv->draftbox ) ),
-			_("Draftbox"), &error );
+			"Draftbox", &error );
 		unconditional_mailbox( gtk_entry_get_text( GTK_ENTRY( self->_priv->trash ) ),
-			_("Trash"), &error );
+			"Trash", &error );
 
 		self->_priv->paths_locked = TRUE;
 
@@ -276,4 +276,4 @@
 		return TRUE;
 	}
 
-}
\ No newline at end of file
+}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]