[Shotwell] Source code reorganization
Jim Nelson
jim at yorba.org
Thu Jan 13 02:36:44 UTC 2011
That sounds great, Bruno. Yes, the one-deep rule is rule of thumb and it
makes perfect sense to break it for the database import code.
-- Jim
On Wed, Jan 12, 2011 at 3:40 PM, Bruno Girin <brunogirin at gmail.com> wrote:
> Hi Jim,
>
> That's great news and will make it a lot easier to navigate the code!
> When I have the time, hopefully in the next few weeks, I'll re-organise
> the AlienDatabase/F-Spot import code into units. However, this brings a
> question: are you happy for me to make an exception to the "one-deep"
> nesting and nest an fspot unit inside an alien_database one?
>
> Cheers,
>
> Bruno
>
> On Tue, 2011-01-11 at 18:53 -0800, Jim Nelson wrote:
> > One item that's been on my mind for a while and was discussed here
> > previously (
> > http://lists.yorba.org/pipermail/shotwell/2010-September/001088.html) is
> > reorganizing Shotwell's source code. With whitespace and comments,
> Shotwell
> > is now over 70,000 lines of code. The old model -- current before about
> an
> > hour ago -- was a flat list of files in a single directory with minimal
> use
> > of namespaces. I've checked in to trunk a new model.
> >
> > Rather than go on about it here, anyone interested should read a page
> I've
> > written about it on our architectural overview:
> > http://trac.yorba.org/wiki/ShotwellArchSourceOrganization
> >
> > If you're currently working on a patch, you'll want to update your local
> > copy and merge with the new code before submitting.
> >
> > Further work will follow to move more of the code into separate units and
> > further clean up the organization. This is a first step toward a more
> > manageable code base. Hopefully from here on it's smaller, more
> incremental
> > changes.
> >
> > Cheers,
> >
> > -- Jim
> > _______________________________________________
> > Shotwell mailing list
> > Shotwell at lists.yorba.org
> > http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
>
>
> _______________________________________________
> Shotwell mailing list
> Shotwell at lists.yorba.org
> http://lists.yorba.org/cgi-bin/mailman/listinfo/shotwell
>
More information about the Shotwell-list
mailing list