>From 27762f83bf8d447e3cb4856919586a43e08089cc Mon Sep 17 00:00:00 2001 From: Joseph Artsimovich Date: Wed, 9 Apr 2014 17:30:35 +0100 Subject: [PATCH] Fix a memory leak in soup_cookie_jar_delete_cookie() A memory leak would happen when asked to delete a matching cookie from a cookie jar that doesn't contain any matching cookies. --- libsoup/soup-cookie-jar.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/libsoup/soup-cookie-jar.c b/libsoup/soup-cookie-jar.c index 8322970..03f3d48 100644 --- a/libsoup/soup-cookie-jar.c +++ b/libsoup/soup-cookie-jar.c @@ -758,9 +758,7 @@ soup_cookie_jar_delete_cookie (SoupCookieJar *jar, priv = SOUP_COOKIE_JAR_GET_PRIVATE (jar); - domain = g_strdup (cookie->domain); - - cookies = g_hash_table_lookup (priv->domains, domain); + cookies = g_hash_table_lookup (priv->domains, cookie->domain); if (cookies == NULL) return; @@ -768,6 +766,7 @@ soup_cookie_jar_delete_cookie (SoupCookieJar *jar, SoupCookie *c = (SoupCookie*)p->data; if (soup_cookie_equal (cookie, c)) { cookies = g_slist_delete_link (cookies, p); + domain = g_strdup (cookie->domain); g_hash_table_insert (priv->domains, domain, cookies); -- 1.7.1