GNOME.org
 

Gtkmm-forge Digest, Vol 27, Issue 15

Send Gtkmm-forge mailing list submissions to
	gtkmm-forge lists sourceforge net

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.sourceforge.net/lists/listinfo/gtkmm-forge
or, via email, send a message with subject or body 'help' to
	gtkmm-forge-request lists sourceforge net

You can reach the person managing the list at
	gtkmm-forge-owner lists sourceforge net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Gtkmm-forge digest..."


gtkmm-forge is the mailing list that receives gtkmm bug reports from bugzilla.  A daily digest is sent to gtkmm-main, to encourage people to help fixing the bugs. Do not try to unsubscribe gtkmm-forge from gtkmm-list.


Today's Topics:

   1. [Bug 547901] Implementing unwrapped copy functions	for
      Glib::NodeTree (glibmm (bugzilla.gnome.org))
   2. [Bug 547889] Implementing C++ version of GNode	test case for
      Glib:NodeTree (glibmm (bugzilla.gnome.org))
   3. [Bug 547909] NodeTree::find_child does not work
      (glibmm (bugzilla.gnome.org))
   4. [Bug 546485] Access control problem in NodeTree API
      (glibmm (bugzilla.gnome.org))
   5. [Bug 547889] Implementing C++ version of GNode	test case for
      Glib:NodeTree (glibmm (bugzilla.gnome.org))
   6. [Bug 547909] NodeTree::find_child does not work
      (glibmm (bugzilla.gnome.org))
   7. [Bug 547909] NodeTree::find_child does not work
      (glibmm (bugzilla.gnome.org))
   8. [Bug 547889] Implementing C++ version of GNode	test case for
      Glib:NodeTree (glibmm (bugzilla.gnome.org))


----------------------------------------------------------------------

Message: 1
Date: Mon, 18 Aug 2008 08:36:46 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547901] Implementing unwrapped copy
	functions	for Glib::NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818083646 B453823F53B label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547901

  glibmm | build | Ver: 2.17.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #2 from Murray Cumming  2008-08-18 08:36 UTC -------
There are maybe some comments missing in the code to explain obvious questions
such as:

a) Why doesn't copy_deep() just use g_node_copy_deep()?
b) Why do we need copy_deep() if we have a copy constructor that does the same
thing? Or doesn't that do a deep copy? I think it should.
c) Why would we want the copy() function that shares the underlying data
pointers? Isn't that just an invitation to memory problems?

The new destructor implementation should also have a comment saying why it
doesn't just use g_node_destroy(). 


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547901.



------------------------------

Message: 2
Date: Mon, 18 Aug 2008 08:47:58 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547889] Implementing C++ version of
	GNode	test case for Glib:NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818084758 12FC223F53B label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547889

  glibmm | tests | Ver: 2.17.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #2 from Murray Cumming  2008-08-18 08:47 UTC -------
I committed that, commenting out the use of NodeTree::copy, which is not yet in
the API.

I would also like to see this use more C++-like variable scope, avoiding reuse
of the same variables, such as "node".


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547889.



------------------------------

Message: 3
Date: Mon, 18 Aug 2008 08:52:04 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547909] NodeTree::find_child does not
	work
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818085204 7DF3523F542 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547909

  glibmm | general | Ver: 2.17.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |murrayc murrayc com




------- Comment #2 from Murray Cumming  2008-08-18 08:52 UTC -------
Could you explain more what is happening here, please.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547909.



------------------------------

Message: 4
Date: Mon, 18 Aug 2008 10:40:38 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 546485] Access control problem in
	NodeTree API
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818104038 19F4223F542 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=546485

  glibmm | general | Ver: 2.17.x




------- Comment #10 from Szil?rd Pfeiffer  2008-08-18 10:40 UTC -------
(In reply to comment #9)
> Thanks. I have added uses of const_cast<> to those const functions. As I said
> above, I prefer not to add the gobj_unconst() function.

My solutions depends on your opinion at comment 6 ("... I think we do have
something like obj_unconst() in some strange places in gtkmm.").

> 
> I don't see how this could have worked anyway without a const_cast<> in here:
> 
>   inline GNode* gobj_unconst() const
>   {
>     return gobject_;
>   }

In NodeTree the type of gobject_ is GNode*, it's value is a non-const (always
created by g_node_new). The gobj() functions (depends on their type) return
with a const/non-const version of gobject_, so you cannot use them in case of a
const function (comment 3), except you use const_cast<> (as you did) which
casts a const version of a surely non-const GNode*, which is not so nice IMHO. 


> 
> Please remember to open closed bugs if you are adding an extra patch to them.
> There's a risk they could be forgotten otherwise.
> 
I'll try not to forget.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=546485.



------------------------------

Message: 5
Date: Mon, 18 Aug 2008 10:47:41 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547889] Implementing C++ version of
	GNode	test case for Glib:NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818104741 2709223F542 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547889

  glibmm | tests | Ver: 2.17.x




------- Comment #3 from Szil?rd Pfeiffer  2008-08-18 10:47 UTC -------
(In reply to comment #2)
> I committed that, commenting out the use of NodeTree::copy, which is not yet in
> the API.
> 

I set this bug to the dependent of bug 547901 to avoid this problem. Was it a
wrong way?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547889.



------------------------------

Message: 6
Date: Mon, 18 Aug 2008 10:50:39 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547909] NodeTree::find_child does not
	work
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818105039 8E07723F544 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547909

  glibmm | general | Ver: 2.17.x




------- Comment #3 from Szil?rd Pfeiffer  2008-08-18 10:50 UTC -------
(In reply to comment #2)
> Could you explain more what is happening here, please.
> 

The same as in case of the function find(). You must bind the address of GNode*
if you want to change it the slot.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547909.



------------------------------

Message: 7
Date: Mon, 18 Aug 2008 11:27:37 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547909] NodeTree::find_child does not
	work
To: gtkmm-forge lists sourceforge net
Message-ID: <20080818112737 7F84123F544 label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547909

  glibmm | general | Ver: 2.17.x

Murray Cumming changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




------- Comment #4 from Murray Cumming  2008-08-18 11:27 UTC -------
Committed. Thanks.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547909.



------------------------------

Message: 8
Date: Tue, 19 Aug 2008 10:00:03 +0000 (UTC)
From: "glibmm (bugzilla.gnome.org)"
	<bugzilla-daemon bugzilla gnome org>
Subject: [gtkmm bugzilla] [Bug 547889] Implementing C++ version of
	GNode	test case for Glib:NodeTree
To: gtkmm-forge lists sourceforge net
Message-ID: <20080819100003 E216C23F59A label gnome org>
Content-Type: text/plain; charset=utf-8

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=547889

  glibmm | tests | Ver: 2.17.x




------- Comment #4 from Murray Cumming  2008-08-19 10:00 UTC -------
Yeah. I just wanted to get some of it in now because it's useful to test the
other things.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=547889.



------------------------------

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

------------------------------

_______________________________________________
Gtkmm-forge mailing list
Gtkmm-forge lists sourceforge net
https://lists.sourceforge.net/lists/listinfo/gtkmm-forge


End of Gtkmm-forge Digest, Vol 27, Issue 15
*******************************************
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]