Re: [PATCH 2/2] kbd: add brazil kbd keys to x11 evdev map

[Joao Luis Meloni Assirati <jlma nonada if usp br>]

On 27-05-2015 11:32, Gerd Hoffmann wrote:
> On Mi, 2015-05-27 at 06:27 -0300, Joao Luis Meloni Assirati wrote:
> > On 26-05-2015 10:58, Gerd Hoffmann wrote:
> > > This patch adds the two extra brazilian keys to the evdev keymap for
> > > X11.  This patch gets the two keys going with the gtk and sdl1 UIs.
> > >
> > > With vnc (remote-viewer) only one of the two works correctly.
> > > Probably a client-side issue.  Not investigated in detail though.
> > >
> > > The SDL2 library complains it doesn't know these keys, so the SDL2
> > > library must be fixed before we can update ui/sdl2-keymap.h
> > >
> > > Signed-off-by: Gerd Hoffmann <kraxel redhat com>
> > > ---
> > >    ui/x_keymap.c | 4 ++--
> > >    1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/ui/x_keymap.c b/ui/x_keymap.c
> > > index b9b0944..4e899b4 100644
> > > --- a/ui/x_keymap.c
> > > +++ b/ui/x_keymap.c
> > > @@ -94,7 +94,7 @@ static const uint8_t x_keycode_to_pc_keycode[115] = {
> > >     */
> > >    
> > >    static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > > -    0,         /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > > +    0x73,      /*  97 EVDEV - RO   ("Internet" Keyboards) */
> > >        0,         /*  98 EVDEV - KATA (Katakana) */
> > >        0,         /*  99 EVDEV - HIRA (Hiragana) */
> > >        0x79,      /* 100 EVDEV - HENK (Henkan) */
> > > @@ -126,7 +126,7 @@ static const uint8_t evdev_keycode_to_pc_keycode[61] = {
> > >        0,         /* 126 EVDEV - I126 ("Internet" Keyboards) */
> > >        0,         /* 127 EVDEV - PAUS */
> > >        0,         /* 128 EVDEV - ???? */
> > > -    0,         /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > > +    0xf0,      /* 129 EVDEV - I129 ("Internet" Keyboards) */
> > >        0xf1,      /* 130 EVDEV - HNGL (Korean Hangul Latin toggle) */
> > >        0xf2,      /* 131 EVDEV - HJCV (Korean Hangul Hanja toggle) */
> > >        0x7d,      /* 132 AE13 (Yen)*/
> > With this patch, the / key now works.
>
> > Unfortunately, the numpad period
> > does not work. Note that /usr/share/qemu/keymaps/pt-br lists 0x34 for
> > KP_Decimal (this is the code my patch was using), instead of 0xf0.
> Which ui is this?  vnc?

No, it is the SDL ui.


> What happens if you change KP_Decimal to 0xf0 in the pt-br keymap?

It makes no difference. And it should make no difference, as I am not 
using the -k switch.

João Luis.