Re: [PATCH v2] Introduce vnc_util_get_version() functions to get version

[Michal Novotny <minovotn redhat com>]

On 10/21/2010 12:32 PM, Daniel P. Berrange wrote:
> On Thu, Oct 21, 2010 at 12:20:33PM +0200, Michal Novotny wrote:
>    
> > Thanks for your guidance Daniel, nevertheless I don't know how is it
> > working with libvirt to define those macros so I tried to implement it
> > to configure.ac using the AC_DEFINE_UNQUOTED directives and this way it
> > was working fine for me.
> >      
> That's correct. AC_SUBST (which libvirt uses) substitutes the
> data into the generated Makefile, while AC_DEFINE_UNQUOTED
> subsitutes the data into config.h which is accessible by source
> code. So the latter is the one you wanted.
>
> Regards,
> Daniel
>    
Ok, so please review version 3 when you have time. Basically it's the 
same except it's using VERSION_{MAJOR,MINOR,MICRO} constants instead of 
parsing then at run-time.

Regards,
Michal

--
Michal Novotny<minovotn redhat com>, RHCE
Virtualization Team (xen userspace), Red Hat