[gtk-vnc-devel] [patch] crash on vnc_display_get_pixbuf()



Hello, this is reported at
https://bugs.launchpad.net/ubuntu/+source/gtk-vnc/+bug/276966

Here is an attempt to fix this issue. I haven't tested it yet, since it
isn't easily reproducible.

Comments?
-- 
Jonh Wendell
http://www.bani.com.br
diff -r d68935d582f0 src/vncdisplay.c
--- a/src/vncdisplay.c	Sun Dec 07 19:56:56 2008 +0000
+++ b/src/vncdisplay.c	Fri Feb 13 11:23:08 2009 -0300
@@ -2020,11 +2020,18 @@
 
 GdkPixbuf *vnc_display_get_pixbuf(VncDisplay *obj)
 {
-	VncDisplayPrivate *priv = obj->priv;
+	VncDisplayPrivate *priv;
 	GdkPixbuf *pixbuf;
+
+	g_return_val_if_fail (VNC_IS_DISPLAY (obj), NULL);
+
+	priv = obj->priv;
 
 	if (!priv->gvnc ||
 	    !gvnc_is_initialized(priv->gvnc))
+		return NULL;
+
+	if (!priv->image)
 		return NULL;
 
 	pixbuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, FALSE, 8,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]