Re: [gtk-vnc-devel] PATCH: Portability to compile under MinGW for Windows



On Wed, Sep 10, 2008 at 03:14:59PM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >This patch addresses the (surprisingly few) portability problems which
> >prevent compilation of gtk-vnc with MinGW. We had already addressed
> >the major problem with the  pthreads based coroutine in the past, and
> >this ties up loose ends. The two issues addressed are a drop in impl
> >of getaddrinfo from GNULIB, and errno / WSAGetLastError() changes.
> >  
> 
> I'm surprised this worked this easily but then I thought that perhaps 
> you've only tested with GNUtls?
> 
> My understanding was that Windows sockets were not file descriptors and 
> that read/write cannot be used with them.  Neither can select.  It's 
> been a long time since I've done windows socket programming though so I 
> may be mistaken.

To be fair, I've only tested compilation :-) I'm still debugging it as
far as being able to actually run it is concerned :-)

Looking at libvirt, I see we did make it use  recv & send, so likely
have to fix that too - though it opens the quesiton of whether these
work with non-sockets ? eg if the app passes a pipe FD into GTK-VNC
directly. I'll just have to experiment.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]