Re: [gtk-vnc-devel] [PATCH] remove unnecessary header from gvnc.c

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Mar 06, 2008 at 02:13:44PM +0900, Atsushi SAKAI wrote:
> Hi,
> 
> This patch removes unnecessary header from gvnc.c
> 
> >From seeing hg annotate src/gvnc.c, redundunt header file exists
>  in early revision.
> I do not know this is policy or not.
> So this patch asks the header policy.
> (It should be redundunt or not.)

The socket related headers you remove *are* required by getaddrinfo()
functions. The compiler may not complain when you remove them, because
they're indirectly included via other headers. The glibc developers
though have a habit of explicitly breaking this indirect includes, so
we should not remove them - we should follow the headers documented in
the man pages

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|