Re: [gtk-vnc-devel] PATCH: Fix opengl rendering z-buffer depth

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Apr 03, 2008 at 10:40:21PM +0100, Daniel P. Berrange wrote:
> On Thu, Apr 03, 2008 at 06:29:41PM -0300, Jonh Wendell wrote:
> > Em Qui, 2008-04-03 às 19:59 +0100, Daniel P. Berrange escreveu:
> > ...
> > > but I found that broke one of my normal X servers. So the patch reverts
> > > that previous change and fixes the texture pixel format. Finally I enable
> > > scaling by default in gvncviewer
> > > 
> > > Dan.
> > 
> > Hi, Dan.
> > 
> > This patch didn't work here. The colors got very strange, like
> > background brown (when it's supposed to be blue). When I tried to take a
> > screenshot, vinagre crashed:
> 
> The crash with the screenshot is a separate issue - that was a problem
> alrady when using GL.  For the odd colours  try applying my patch without
> the following chunk:
> 
> -                               GL_BGRA_EXT /* GL_RGB */,
> +                               GL_RGBA,

Ok, yes this chunk is bogus - if people are OK with the rest, I'll commit
it minus this chunk.

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|