FYI: trivial fix for GdkRegion->get_rectangles



Just FYI, I checked in the following trivial fix:

Index: ChangeLog
===================================================================
RCS file: /cvsroot/gtk2-perl/gtk2-perl-xs/Gtk2/ChangeLog,v
retrieving revision 1.669
diff -u -p -r1.669 ChangeLog
--- ChangeLog   2 Feb 2006 20:25:52 -0000       1.669
+++ ChangeLog   5 Feb 2006 04:28:32 -0000
@@ -1,3 +1,7 @@
+2006/02/05 04:26 pcg
+
+       * xs/GdkRegion.xs: Fix access after free() in get_rectangles.
+
 2006/02/02     muppetman
 
        * xs/GtkWidget.xs: Silly logic error in _INSTALL_OVERRIDES caused 
Index: xs/GdkRegion.xs
===================================================================
RCS file: /cvsroot/gtk2-perl/gtk2-perl-xs/Gtk2/xs/GdkRegion.xs,v
retrieving revision 1.6
diff -u -p -r1.6 GdkRegion.xs
--- xs/GdkRegion.xs     5 Jan 2004 16:45:06 -0000       1.6
+++ xs/GdkRegion.xs     5 Feb 2006 04:28:33 -0000
@@ -143,7 +143,7 @@ gdk_region_get_rectangles (region)
        gdk_region_get_rectangles (region, &rectangles, &n_rectangles);
        EXTEND (SP, n_rectangles);
        for (i = 0 ; i < n_rectangles ; i++)
-               PUSHs (sv_2mortal (newSVGdkRectangle (rectangles + i)));
+               PUSHs (sv_2mortal (newSVGdkRectangle_copy (rectangles + i)));
        g_free (rectangles);
 
 ##  gboolean gdk_region_empty (GdkRegion *region) 

-- 
                The choice of a
      -----==-     _GNU_
      ----==-- _       generation     Marc Lehmann
      ---==---(_)__  __ ____  __      pcg goof com
      --==---/ / _ \/ // /\ \/ /      http://schmorp.de/
      -=====/_/_//_/\_,_/ /_/\_\      XX11-RIPE



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]