Re: [gpm] Waiting for patch review for 9 months

[Alex Launi <alex launi gmail com>]

Patch updated in bugzilla

On Fri, Nov 26, 2010 at 3:45 AM, Richard Hughes <hughsient gmail com> wrote:

Apologies. Bugzilla is a horrible way for people in interact, and

you've done the right thing and emailed me. If you do IRC, I'm also
hughsie on Gimpnet and freenode and that gets you an instant response.

Good to know, thanks for the warm welcome! 

Anyway, for the patch:

       if (kind == UP_DEVICE_KIND_BATTERY) {
               /* TRANSLATORS: laptop battery is now discharging */
-               title = _("Battery Discharging");
+               title = _("AC power disconnected");


This is fine, although perhaps "Using battery power" might be clearer.

Yeah, better.

 

               if (remaining_text != NULL) {
                       /* TRANSLATORS: tell the user how much time they have got */
                       message = g_strdup_printf (_("%s of battery power remaining
(%.0f%%)"), remaining_text, percentage);
               } else {
-                       message = g_strdup_printf ("%s (%.0f%%)", device_desc, percentage);
+                       message = g_strdup_printf (_("%.0f%% of %s remaining"),
percentage, device_desc);

Two things. If you're adding a translator string, you need to add a
comment above starting with TRANSLATORS: and then a hint to what the
string is and how to translate it. The other is that translators hate
string surgery, and would much prefer a string like "_("%.0f%% battery
power remaining")

I'm not sure what you mean by string surgery. Also (sorry translators), but I'd rather have a nicer reading string than our translators sitting around getting fat from us avoiding string changes.

 

       } else if (kind == UP_DEVICE_KIND_UPS) {
               /* TRANSLATORS: UPS is now discharging */
-               title = _("UPS Discharging");
+               title = _("Running on UPS power");

"Using UPS power"?

Better, I kind of thought running was too colloquial.

 

               if (remaining_text != NULL) {
                       /* TRANSLATORS: tell the user how much time they have got */
                       message = g_strdup_printf (_("%s of UPS backup power remaining
(%.0f%%)"), remaining_text, percentage);
               } else {
-                       message = g_strdup (gpm_device_to_localised_string (device));
-                       message = g_strdup_printf ("%s (%.0f%%)", device_desc, percentage);
+                       message = g_strdup_printf (_("%.0f%% of %s remaining"),
percentage, device_desc);

"7% of UPS remaining" -- it makes it sounds like the UPS is vanishing
into thin air? what about "7% of UPS power remaining"

Oh god not the UPS!

-- 
--Alex Launi