Re: [gpm] [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer
- From: Alan Jenkins <alan-jenkins tuffmail co uk>
- To: Richard Hughes <hughsient gmail com>
- Cc: gnome-power-manager-list gnome org, acpi4asus-user lists sourceforge net, linux-kernel vger kernel org, Corentin Chary <corentin chary gmail com>, Darren Salt <linux youmustbejoking demon co uk>
- Subject: Re: [gpm] [PATCH 2.6.29] eeepc-laptop: report brightness control events via the input layer
- Date: Tue, 16 Jun 2009 09:34:28 +0100
Richard Hughes wrote:
> On Mon, Jun 15, 2009 at 9:09 AM, Alan
> Jenkins<alan-jenkins tuffmail co uk> wrote:
>
>> So during step iii) I think you see the firmware
>> increase the brightness, then g-p-m decrease the brightness, and then
>> g-p-m catches up and the brightness increases again.
>>
>
> Sorry for not responding sooner, been moving house.
>
> I don't think the kernel driver should modify the brightness itself,
> as that's applying policy. Is this is left to userspace then we can
> put on policy such as "don't allow brightness to be set below 30%" or
> "automatically set the brightness using a ambient light sensor, and
> use the brightness keys to set ambient thresholds".
>
> Doing this policy in the driver is the wrong thing to do IMO.
>
> Richard.
>
The driver doesn't. As far as we know, none of them do. Firmware does.
Thanks
Alan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]