[gpm] warning icon not appropriate when using battery charge control features



Hi,
I've got a thinkpad T60 and have battery charge control features enabled:
    # echo 40 > /sys/devices/platform/smapi/BAT0/start_charge_thresh
    # echo 100 > /sys/devices/platform/smapi/BAT0/stop_charge_thresh
upon this setup,when the battery  capacity is about say 80% and AC power
is on, the battery is in a state of   not charging nor fully charged.thus
g-p-m applet shows an warning icon.This is not as g-p-m 2.24 has worked.

line 131 of  src/gpm-devicekit.c says:
		} else if (state == DKP_DEVICE_STATE_UNKNOWN && percentage > 95.0f) {
			egg_warning ("fixing up unknown %f", percentage);
			filename = g_strdup_printf ("gpm-%s-charged", prefix);

I think here the percentage > 95.0f  here is too strict and unnecessary.

what do you think?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]