Camera profile generation options

[Pascal de Bruijn]

On Mon, Feb 8, 2010 at 4:12 PM, Richard Hughes <hughsient at gmail.com> wrote:
> On 8 February 2010 15:04, Pascal de Bruijn <pmjdebruijn at pcode.nl> wrote:
>> Are camera profiles generated with Argyll's default options? -q m -a l ?
>>
>> This might be fine for IT8 or other targets with lots of patches...
>>
>> But it's probably not such a good idea for a 24 patch ColorChecker, -q
>> l -a S seems more appropriate...
>
> Yes, this is a good idea, and a perfect patch for you to submit :-)
>
> The kind of profile is listed in src/gcm-calibrate-argyll.h, which is
> saved to priv->reference_kind, which is private data for the
> GcmCalibrateArgyll object. You probably need to add a simple "if
> (priv->reference_kind ==
> GCM_CALIBRATE_ARGYLL_REFERENCE_KIND_COLOR_CHECKER)" rather than just
> getting the type of profile (using
> gcm_calibrate_argyll_precision_to_quality_arg) in the function
> gcm_calibrate_argyll_device_generate_profile() which lives in
> src/gcm-calibrate-argyll.c
>
> Make a few changes, and just do "git diff > test.patch"

I think this patch should do it, it seems to work, though I didn't
extensively test it.

I also included the QPcard as well, it's a similar target...

Regards,
Pascal de Bruijn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcm-calibrate-argyll-low-patch-count-target-low-quality-single-shaper.patch
Type: text/x-patch
Size: 2556 bytes
Desc: not available
URL: <http://mail.gnome.org/archives/gnome-color-manager-list/attachments/20100208/a60c4093/attachment-0004.bin>