Re: Two small incompatible changes

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On 17 Nov 2001, Owen Taylor wrote:
> 
> > 
> > Sat Nov 17 19:26:20 2001  Owen Taylor  <otaylor redhat com>
> > 
> > 	* gtk/gtkwindow.c (gtk_window_key_press_event): Reprioritize
> > 	key bindings in order of visibility: mnemonics, then 
> > 	accelerators, then send key to the focus widget, then
> > 	bindings on the GtkWindow.
> 
> send key to the focus widget, and then bindings on GtkWindow?
> what happened to propagating unhandled keypresses from the focus
> widget up through parents to the window to get Ctrl+PgUp on
> notebooks going?
> or do you intend to implement that via a key_press_event connection
> of notebook on window (upon hierachy changed for instance)?
> if the later, i have no real objections to that, it's probably
> introducing the least breakage. though it scales badly, that kludge
> is probably only needed for notebooks currently.

I was just abbreviating when I said "to the focus widget" -
I in fact mean "to the widget and propagating up through its
ancestors to the window". I checked in that change a couple
of days ago.

Regards,
                                        Owen

(Not just notebooks, at least also paned widgets.)