Re: [gmime-devel] [PATCH] GMimeFilterHtml: add option to enclose citation in

[Gaute Hope <eg gaute vetsj com>]

Ok, no worries. I'll keep testing it. And probably take a look at your
MimeKit implementation if there is anything I missed.

I've seen a few ad-hoc implementations of the same feature (e.g. Geary),
so I think it would be interesting for other users.

On the code: I was a little bit confused about what inend and instart is
in html_convert.

Regards, Gaute

Jeffrey Stedfast writes on April 22, 2016 14:43:
> Hey,
>
> I just saw the patch added to bugzilla. Awesome, thanks, I was going to 
> recommend that :)
>
> I've got a lot on my plate for the next month or so, so I might not get 
> a chance to look it over for a bit.
>
> I think the idea sounds reasonable and it sounds a lot like what I did 
> with http://github.com/jstedfast/MimeKit's text->html converter, if I 
> understand what your patch is meant to do correctly.
>
> It's been so long since I've looked at that code, I hardly remember what 
> it does anymore :(
>
> Jeff
>
> On 4/20/2016 8:46 AM, Gaute Hope wrote:
> > Gaute Hope writes on April 20, 2016 14:19:
> > > Hi,
> > >
> > > this patch adds an option to the GMimeFilterHtml: 
> > > GMIME_FILTER_HTML_BLOCKQUOTE_CITATION which encloses citations in 
> > > blockquotes. This makes it easier to customize the HTML with CSS 
> > > afterwards.
> > >
> > >
> > > It currently disables the MARK_CITATION code.
> > >
> > > I delete the existing '>' chars, however this does not work perfect 
> > > (probably in cases where a space has been added inbetween them).
> > >
> > > Please consider this for inclusion in gmime.
> >
> > Please find updated version here: 
> > https://github.com/gauteh/gmime/tree/blockquote_html
> >
> >
> > Regards, Gaute
> > _______________________________________________
> > gmime-devel-list mailing list
> > gmime-devel-list gnome org
> > https://mail.gnome.org/mailman/listinfo/gmime-devel-list