From dennisn at dennisn.mooo.com Sat Nov 8 14:31:27 2014 From: dennisn at dennisn.mooo.com (Dennis New) Date: Sat, 8 Nov 2014 09:31:27 -0500 Subject: [Ekiga-list] pip resizing and moving Message-ID: <20141108093127.98517ecd796f64c8341ba28e@dennisn.mooo.com> Here's a patch (against 4.0.1) to make the Picture-In-Picture (PIP) resizable and moveable, by right-clicking in the window. It can be moved to any of the four corners, depending on which quadrant you right click. It resizes the width to the x-offset from the edge. By the way, is everyone (linux users at least) able to get Fullscreen video through the Call Window? I am able to, and I can Alt-Enter it too to get a fully resizable window. Ideally, the main Call Window should be resizeable like this too, no? I can change the GTK setting to make it resizable, but I'm unsure of where/how to handle the callbacks to redraw/scale the video. I am also not able to use Fullscreen when I'm not in a call session -- ie. when I'm just viewing my local video. Perhaps this is because the Fullscreen mode requires a remote PIP? -------------- next part -------------- A non-text attachment was scrubbed... Name: ekiga-pip-resizing-moving.patch Type: application/octet-stream Size: 7848 bytes Desc: not available URL: From eugen.dedu at univ-fcomte.fr Sun Nov 9 05:45:26 2014 From: eugen.dedu at univ-fcomte.fr (Eugen Dedu) Date: Sun, 09 Nov 2014 00:45:26 -0500 Subject: [Ekiga-list] pip resizing and moving In-Reply-To: <20141108093127.98517ecd796f64c8341ba28e@dennisn.mooo.com> References: <20141108093127.98517ecd796f64c8341ba28e@dennisn.mooo.com> Message-ID: <545EFF76.90506@univ-fcomte.fr> On 08/11/14 09:31, Dennis New wrote: > Here's a patch (against 4.0.1) to make the Picture-In-Picture (PIP) > resizable and moveable, by right-clicking in the window. It can be > moved to any of the four corners, depending on which quadrant you right > click. It resizes the width to the x-offset from the edge. > > By the way, is everyone (linux users at least) able to get Fullscreen > video through the Call Window? I am able to, and I can Alt-Enter it too > to get a fully resizable window. Ideally, the main Call Window should > be resizeable like this too, no? I can change the GTK setting to make > it resizable, but I'm unsure of where/how to handle the callbacks to > redraw/scale the video. I am also not able to use Fullscreen when I'm > not in a call session -- ie. when I'm just viewing my local video. > Perhaps this is because the Fullscreen mode requires a remote PIP? Thank you very much for this patch. This is a really useful feature. Unfortunately, it does not apply to development branch (master), where xwindow code has been replaced with clutter/gstreamer/... I would love to integrate a patch for that feature, however before that the patch should be done on current master, and moreover Damien is working on a branch ds-gtk-application which perhaps changes even further the code involved. So I would sadly say that, if you want to implement such a feature, you should wait a bit until Damien merges his branch to master, and create a patch afterwards based on master. (Damien, if you have another idea, please discuss.) -- Eugen From eugen.dedu at univ-fcomte.fr Sun Nov 9 05:47:48 2014 From: eugen.dedu at univ-fcomte.fr (Eugen Dedu) Date: Sun, 09 Nov 2014 00:47:48 -0500 Subject: [Ekiga-list] pip resizing and moving In-Reply-To: <20141108093127.98517ecd796f64c8341ba28e@dennisn.mooo.com> References: <20141108093127.98517ecd796f64c8341ba28e@dennisn.mooo.com> Message-ID: <545F0004.9020108@univ-fcomte.fr> On 08/11/14 09:31, Dennis New wrote: > By the way, is everyone (linux users at least) able to get Fullscreen > video through the Call Window? I am able to, and I can Alt-Enter it too > to get a fully resizable window. Ideally, the main Call Window should > be resizeable like this too, no? I can change the GTK setting to make > it resizable, but I'm unsure of where/how to handle the callbacks to In ds-gtk-application branch, video is (finally!) resizeable. > redraw/scale the video. I am also not able to use Fullscreen when I'm > not in a call session -- ie. when I'm just viewing my local video. > Perhaps this is because the Fullscreen mode requires a remote PIP? Indeed. This is a wrong idea, and as far as I know it has been fixed too in Damien's branch. -- Eugen From dsandras at seconix.com Sun Nov 16 09:31:15 2014 From: dsandras at seconix.com (Damien Sandras) Date: Sun, 16 Nov 2014 10:31:15 +0100 Subject: [Ekiga-list] pip resizing and moving In-Reply-To: <545F0004.9020108@univ-fcomte.fr> References: <20141108093127.98517ecd796f64c8341ba28e@dennisn.mooo.com> <545F0004.9020108@univ-fcomte.fr> Message-ID: <1416130275.26727.2.camel@seconix.com> Le dimanche 09 novembre 2014 ? 00:47 -0500, Eugen Dedu a ?crit : > On 08/11/14 09:31, Dennis New wrote: > > By the way, is everyone (linux users at least) able to get Fullscreen > > video through the Call Window? I am able to, and I can Alt-Enter it too > > to get a fully resizable window. Ideally, the main Call Window should > > be resizeable like this too, no? I can change the GTK setting to make > > it resizable, but I'm unsure of where/how to handle the callbacks to > > In ds-gtk-application branch, video is (finally!) resizeable. > > > redraw/scale the video. I am also not able to use Fullscreen when I'm > > not in a call session -- ie. when I'm just viewing my local video. > > Perhaps this is because the Fullscreen mode requires a remote PIP? > > Indeed. This is a wrong idea, and as far as I know it has been fixed > too in Damien's branch. > Yes, all of this works correctly. Unfortunately, it is still impossible to choose where the PIP frame has to be displayed. I am not sure if I will have the time to reimplement it. Changing the UI was an enormous job (I am busy on this since more than 1 year - spare time only), and we still have to add new SIP features, then improve Ekiga.net... -- Damien Sandras -------------- next part -------------- An HTML attachment was scrubbed... URL: