From gunnar@gervin.no Tue Oct 19 09:14:41 2010 Return-Path: X-Original-To: desktop-testing-list@gnome.org Delivered-To: desktop-testing-list@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 6C330750152 for ; Tue, 19 Oct 2010 09:14:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -1.469 X-Spam-Level: X-Spam-Status: No, score=-1.469 tagged_above=-999 required=2 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_HTML_MOSTLY=0.428, RCVD_IN_DNSWL_NONE=-0.0001, TVD_SPACE_RATIO=0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i7v7EhzEVuF8 for ; Tue, 19 Oct 2010 09:14:40 +0000 (UTC) X-Greylist: delayed 504 seconds by postgrey-1.32 at menubar.gnome.org; Tue, 19 Oct 2010 09:14:39 UTC Received: from webmail-out2.b-one.net (webmail-out2.one.com [91.198.169.17]) by menubar.gnome.org (Postfix) with ESMTP id D4B81750116 for ; Tue, 19 Oct 2010 09:14:31 +0000 (UTC) Received: from bmail00.one.com (bmail00.one.com [91.198.169.176]) by webmail-out2.b-one.net (Postfix) with ESMTP id 973D320403A5A for ; Tue, 19 Oct 2010 11:06:03 +0200 (CEST) Received: by bmail00.one.com (Postfix, from userid 33) id 90FEC304A02D; Tue, 19 Oct 2010 11:06:03 +0200 (CEST) MIME-Version: 1.0 From: "Gunnar Gervin" To: desktop-testing-list@gnome.org Date: Tue, 19 Oct 2010 11:06:03 +0200 X-Mailer: One.com webmail X-Sender: gunnar@gervin.no X-Originating-Ip: 80.202.58.112 Received: from 80.202.58.112 by webmail.one.com with HTTP; Tue, 19 Oct 2010 11:06:03 +0200 Content-Type: multipart/alternative; boundary="----------=_1287479163-28865-0" Message-Id: <20101019090603.90FEC304A02D@bmail00.one.com> Subject: [gnome-desktop-testing] svar 1.gang X-BeenThere: desktop-testing-list@gnome.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "GNOME Desktop Testing - Visit http://live.gnome.org/DesktopTesting for more info" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2010 09:14:41 -0000 This is a multi-part message in MIME format... ------------=_1287479163-28865-0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 ------------=_1287479163-28865-0 Content-Type: text/html; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable = ------------=_1287479163-28865-0-- From ara@ubuntu.com Wed Oct 20 10:31:40 2010 Return-Path: X-Original-To: desktop-testing-list@gnome.org Delivered-To: desktop-testing-list@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 30CDF750227 for ; Wed, 20 Oct 2010 10:31:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.6 X-Spam-Level: X-Spam-Status: No, score=-2.6 tagged_above=-999 required=2 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G4OM1GKNG9Jr for ; Wed, 20 Oct 2010 10:31:37 +0000 (UTC) Received: from adelie.canonical.com (adelie.canonical.com [91.189.90.139]) by menubar.gnome.org (Postfix) with ESMTP id E4D927501AA for ; Wed, 20 Oct 2010 10:31:28 +0000 (UTC) Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1P8Vx7-0003g0-SJ for ; Wed, 20 Oct 2010 11:31:26 +0100 Received: from i59f7b502.versanet.de ([89.247.181.2] helo=[192.168.100.120]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1P8Vx7-0001gs-PL for desktop-testing-list@gnome.org; Wed, 20 Oct 2010 11:31:25 +0100 Message-ID: <4CBEC4FC.2000005@ubuntu.com> Date: Wed, 20 Oct 2010 12:31:24 +0200 From: Ara Pulido User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100922 Thunderbird/3.1.4 MIME-Version: 1.0 To: desktop-testing-list@gnome.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [gnome-desktop-testing] Cleaning up Mago code X-BeenThere: desktop-testing-list@gnome.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "GNOME Desktop Testing - Visit http://live.gnome.org/DesktopTesting for more info" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2010 10:31:40 -0000 Hello all, As part of UDS Maverick, we talked about making the Mago code a lot cleaner. The most important bit of this was splitting the gnome.py and ubuntu.py into the different applications. Jeff took care of that one. The next step would be to avoid the unnecessary try/catch blocks that are all over the application wrappers. The main reason of these blocks were to give a correct error message, when LDTP didn't give us one. We are going to avoid these blocks, and, whenever LDTP gives a wrong (or not clear) error message, we are going to file a bug against LDTP instead. This will make Mago code cleaner, and we will be improving LDTP. I have created a branch with this code and I will merge it with trunk, at least I receive any comments or concerns. Feel free to share your thoughts here, or in the merge proposal [1] Thanks! Ara. [1] https://code.launchpad.net/~apulido/mago/cleaner_happier/+merge/38923