Re: NetworkManager static-routes support patch

[Derek Atkins <warlord MIT EDU>]

Quoting Dan Williams <dcbw redhat com>:

> On Thu, 2007-06-07 at 15:12 +0200, Blonďák wrote:
> > Hi,
> > i wrote patch for NetworkManager for support static-routes from DHCP
> > (033).
>
> Nice!  A few comments...
>
> - instead of doing "(*temp_route).host", just use "temp_route->host".
> That shows up in a few places.
>
> - do static routes -always- have a netmask of 0xffffffff?

-host routes do. -net routes do not.

-derek

--
      Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
      Member, MIT Student Information Processing Board  (SIPB)
      URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
      warlord MIT EDU                        PGP key available