Re: [PATCH] option to display formulas

[Miguel de Icaza <miguel gnu org>]

Hello,

> 	  str = cell_get_formatted_val (cell, &color);
> +	if
> (cell->sheet->workbook->display_formulas && cell->parsed_node){
> +
> ParsePosition pp;
> +		char *tmpstr = expr_decode_tree (cell->parsed_node,
> +
> 				   parse_pos_cell (&pp, cell));
> +		g_free (str);
> +		str = g_strconcat
> ("=", tmpstr, NULL);
> +		g_free (tmpstr);
> +	}

It seems like this could be optimized, to avoid computing the value
for "str" if the setting is to show formulas.

> +toggle_formulas_cmd (GtkWidget *widget, Workbook *wb)
> +{
> +
> wb->display_formulas = !wb->display_formulas;
> +	workbook_recalc_all
> (wb);
> +}

In this case, we should probably just queue a redraw on all exposed
sheets, rather than queue a recomputation.

Also, I think we need to save and load the state for the
display_formulas setting.

Best wishes,
miguel.