Re: Hacker, can I release 0.45?

[Philippe Defert cern ch]

Bruno Mairlot writes:
 > Miguel de Icaza wrote:
 > > 
 > > Well, you really should upgrade your gnome-print :-)
 > > 
 > > Miguel.
 > 
 > 
 > Miguel,
 > 
 > (I'm genuflected...cf prec mail :-)
 > 
 > My apologizes if it is gnome-print, but how would I know it is due to 
 > gnome-print, since the install process of 0.10 crash ? (The make is Ok)
 > on my box : RH 6.1 
 > PII 400
 > 
 > Here is a log : 
 > 
 > 
 > make[2]: Entering directory `/Work/maehdros/gnome/gnome-print-0.10'
 > /bin/sh ./mkinstalldirs /opt/gnome/bin
 >  /bin/sh ./libtool  --mode=install /usr/bin/install -c 
 > gnome-font-install /opt/gnome/bin/gnome-font-install
 > /usr/bin/install -c gnome-font-install /opt/gnome/bin/gnome-font-install
 > /bin/sh ./mkinstalldirs /opt/gnome/lib
 >  /usr/bin/install -c -m 644 ./printConf.sh /opt/gnome/lib/printConf.sh
 > ./gnome-font-install --system --scan --no-copy                  \
 >         --afm-path=/opt/gnome/share/fonts/afms                  \
 >         --pfb-path=/opt/gnome/share/fonts/pfbs                  \
 >         --fontmap-path=/opt/gnome/share/fonts                          
 > \
 >         --afm-assignment=ghostscript,/usr/share/ghostscript/5.10
 > --pfb-assignment=ghostscript,/usr/share/ghostscript/5.10
 > --afm-assignment=ghostscript,/usr/share/fonts/default/ghostscript
 > --pfb-assignment=ghostscript,/usr/share/fonts/default/ghostscript
 > --afm-assignment=ghostscript,/usr/share/fonts/default/Type1
 > --pfb-assignment=ghostscript,/usr/share/fonts/default/Type1                                    
 > \
 >         --pfb-assignment=ghostscript,/usr/share/ghostscript/fonts \
 >         --pfb-assignment=ghostscript,/usr/lib/ghostscript/fonts   \
 >         --pfb-assignment=ghostscript,/usr/share/fonts/default/Type1 \
 >        
 > --pfb-assignment=ghostscript,/usr/share/fonts/default/ghostscript \
 >         --afm-assignment=ghostscript,/usr/share/ghostscript/fonts \
 >         --afm-assignment=ghostscript,/usr/lib/ghostscript/fonts   \
 >         --afm-assignment=ghostscript,/usr/share/fonts/default/Type1 \
 >        
 > --afm-assignment=ghostscript,/usr/share/fonts/default/ghostscript \
 >         ./fonts/
 > /opt/gnome/share/fonts/fontmap
 > make[2]: *** [install-data-local] Segmentation fault
 > make[2]: Leaving directory `/Work/maehdros/gnome/gnome-print-0.10'
 > make[1]: *** [install-am] Error 2
 > make[1]: Leaving directory `/Work/maehdros/gnome/gnome-print-0.10'
 > make: *** [install-recursive] Error 1
 > 
 > I don't have recompiled gnumeric yet, then I will tell you.
 > 
 > Bruno


It happened to me too.

I looked at the code and I think that when the directory where the
fontmap file should be installed does not exist before then the
segfault happens. If the directory exists and the ermissions are not
right than the fontmap file is not created without any error/warning
being issued. This is all in the open statements the return value of
which are not checked. When I sent a patch to allow for redirection of
the "fontmap" file at installation time, I did not have time to secure
all these opens which were not safely handled in the old code...

Amicalement.
Philippe.