Re: SMB module authentication rewrite patch

[Narayana Pattipati <narayana pattipati wipro com>]

Hi,

I applied this patch and tested it once. 

Looks like the deadlock issue is solved. I can see it working fine without any deadlocks. But, I see the following issues with the patch (or may be they were already there in the earlier code). I just tested the patch, did not look at code changes.

a) Typing smb:// does not list workgroups for me. It was working without the patch. I am not sure if someone else saw the same issue.

b) Entering smb://domain;username machine throws a password dialog but it never authenticated user. Even after giving correct password, the authentication dialog keeps coming.  This is use case while adding a  network place from network: location. User can either enter username or go without user name. If user enters a username there, url becomes as mentioned above, and user will encounter the problem.

I will let you know if I see any other issues with the patch.

Regards,
Narayana

On Thu, 2005-01-06 at 07:38, Nielsen wrote:
> I've updated and tested the patch. The new patch is found here:
> http://bugzilla.gnome.org/show_bug.cgi?id=132933
>
> As noted earlier this patch rewrites most of the gnome-vfs SMB 
> authentication code. The previous code deadlocks under circumstances.
>
> The per server caching issue isn't tackled in this patch yet, but this 
> is the first step and should increase stability greatly. It would be 
> nice to get this reviewed, critiqued and into GNOME 2.10 before the 
> feature freeze on Jan 10th.
>
> Cheers,
> Nate
>
> _______________________________________________
> gnome-vfs-list mailing list
> gnome-vfs-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-vfs-list