Re: more NM patches



Il giorno ven, 25/03/2011 alle 14.15 -0400, Dan Winship ha scritto:
> _______________________________________________
> gnome-shell-list mailing list
> gnome-shell-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-shell-list

Reviews:
0001: Isn't this calling _reposition for every frame? Every call to
_reposition queues a relayout, which in turns result in _allocate, and
then to queue a _reposition.

0002: Looks good.

0003: The fix is consistent with current background-image support, and
good as a bandaid, until background-position / background-size /
background-repeat are supported. But I'm not sure it does fix any of the
sizing bug, given that the font size does not change (and if it does, we
have a problem somewhere else, either with cascading or with style
classes that are not removed)

0004: Looks good.

Giovanni


Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]