From begue.jc@gmail.com Fri Jan 11 09:40:46 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 3651D7500B6 for ; Fri, 11 Jan 2008 09:40:46 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.072 X-Spam-Level: X-Spam-Status: No, score=-2.072 tagged_above=-999 required=2 tests=[BAYES_00=-2.599, HTML_30_40=0.374, HTML_MESSAGE=0.001, SARE_SUB_ENC_UTF8=0.152] X-Amavis-OS-Fingerprint: Linux 2.6 (newer, 2) (firewall!) (up: 8426 hrs), (distance 16, link: (Google 2)), [72.14.220.159] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xkuMfcSbXub0 for ; Fri, 11 Jan 2008 09:40:43 +0000 (GMT) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.159]) by menubar.gnome.org (Postfix) with ESMTP id F0AA675007E for ; Fri, 11 Jan 2008 09:40:42 +0000 (GMT) Received: by fg-out-1718.google.com with SMTP id d23so1155597fga.33 for ; Fri, 11 Jan 2008 01:40:42 -0800 (PST) Received: by 10.82.107.15 with SMTP id f15mr4952601buc.0.1200044442512; Fri, 11 Jan 2008 01:40:42 -0800 (PST) Received: from ?192.168.0.2? ( [82.234.221.170]) by mx.google.com with ESMTPS id y2sm8694108mug.9.2008.01.11.01.40.41 (version=SSLv3 cipher=RC4-MD5); Fri, 11 Jan 2008 01:40:41 -0800 (PST) From: Jean-Christophe BEGUE To: evolution-patches@gnome.org Content-Type: multipart/mixed; boundary="=-Vi1AOVVbvAM33Z0vBDeW" Date: Fri, 11 Jan 2008 10:39:38 +0100 Message-Id: <1200044378.6337.8.camel@jc-ulaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.21.5 Subject: [evolution-patches] =?utf-8?q?Bug_329692_=E2=80=93_attachment_siz?= =?utf-8?q?e_in_composer_not=09shown_when_reopening?= X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 09:40:46 -0000 --=-Vi1AOVVbvAM33Z0vBDeW Content-Type: multipart/alternative; boundary="=-dWg3N7oo4ywa/dKVvRPY" --=-dWg3N7oo4ywa/dKVvRPY Content-Type: text/plain Content-Transfer-Encoding: 7bit Hello, This bug implies both evolution and evolution-data-server. I added a function called camel_mime_part_get_content_size () to evolution-data-server/camel/mime-part.c and used it in evolution/widget/misc/attachment.c. There's still a problem: the size displayed is bigger than the real file size because camel_data_wrapper_decode_to_stream () (used with an null stream to get the size) returns size of encoded data. How could i fix it? This is my first patch, I hope i did everything right.(Please tell me what i did wrong.) Sorry for my english. Regards, Jean-Christophe BEGUE --=-dWg3N7oo4ywa/dKVvRPY Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit Hello,

This bug implies both evolution and evolution-data-server. I added a function called
camel_mime_part_get_content_size () to evolution-data-server/camel/mime-part.c and
used it in evolution/widget/misc/attachment.c.

There's still a problem: the size displayed is bigger than the real file size because
camel_data_wrapper_decode_to_stream () (used with an null stream to get the size) returns
size of encoded data. How could i fix it?

This is my first patch, I hope i did everything right.(Please tell me what i did wrong.)

Sorry for my english.

Regards,

Jean-Christophe BEGUE --=-dWg3N7oo4ywa/dKVvRPY-- --=-Vi1AOVVbvAM33Z0vBDeW Content-Disposition: attachment; filename=evolution329692.diff Content-Type: text/x-patch; name=evolution329692.diff; charset=UTF-8 Content-Transfer-Encoding: 8bit Index: widgets/misc/e-attachment.c =================================================================== --- widgets/misc/e-attachment.c (révision 34779) +++ widgets/misc/e-attachment.c (copie de travail) @@ -600,7 +600,7 @@ new->body = part; new->guessed_type = FALSE; new->is_available_local = TRUE; - new->size = 0; + new->size = camel_mime_part_get_content_size (part); new->file_name = g_strdup (camel_mime_part_get_filename(part)); return new; --=-Vi1AOVVbvAM33Z0vBDeW Content-Disposition: attachment; filename=evolution-data-server-329692.diff Content-Type: text/x-patch; name=evolution-data-server-329692.diff; charset=UTF-8 Content-Transfer-Encoding: 8bit Index: camel/camel-mime-part.c =================================================================== --- camel/camel-mime-part.c (révision 8343) +++ camel/camel-mime-part.c (copie de travail) @@ -1060,3 +1060,25 @@ medium->content = NULL; } } + +/** + * camel_mime_part_get_content_size + * @mime_part: a #CamelMimePart object + * + * Function used to get the size of the mime part provided data. + **/ + +ssize_t +camel_mime_part_get_content_size (CamelMimePart *mime_part) +{ + ssize_t written; + CamelStreamNull *nstream; + CamelMedium *medium = CAMEL_MEDIUM (mime_part); + CamelDataWrapper *dw = camel_medium_get_content_object (medium); + + nstream = camel_stream_null_new (); + written = camel_data_wrapper_write_to_stream (dw, nstream); + camel_object_unref (nstream); + + return written; +} Index: camel/camel-mime-part.h =================================================================== --- camel/camel-mime-part.h (révision 8343) +++ camel/camel-mime-part.h (copie de travail) @@ -103,6 +103,8 @@ void camel_mime_part_set_content (CamelMimePart *mime_part, const char *content, int length, const char *type); +ssize_t camel_mime_part_get_content_size (CamelMimePart *mime_part); + G_END_DECLS #endif /* CAMEL_MIME_PART_H */ --=-Vi1AOVVbvAM33Z0vBDeW-- From fejj@novell.com Fri Jan 11 21:01:23 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 374B2750399 for ; Fri, 11 Jan 2008 21:01:23 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.37 X-Spam-Level: X-Spam-Status: No, score=-2.37 tagged_above=-999 required=2 tests=[BAYES_00=-2.599, SARE_SUB_ENC_UTF8=0.152, TW_GT=0.077] X-Amavis-OS-Fingerprint: Linux 2.4-2.6 (up: 4463 hrs), (distance 11, link: PIX, SMC, sometimes wireless), [137.65.250.26] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VeFs-nUZ0J10 for ; Fri, 11 Jan 2008 21:01:20 +0000 (GMT) Received: from victor.provo.novell.com (victor.provo.novell.com [137.65.250.26]) by menubar.gnome.org (Postfix) with ESMTP id 2DFCD75042C for ; Fri, 11 Jan 2008 20:42:29 +0000 (GMT) Received: from [164.99.120.160] (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP (TLS encrypted); Fri, 11 Jan 2008 13:42:15 -0700 From: Jeffrey Stedfast To: Jean-Christophe BEGUE In-Reply-To: <1200044378.6337.8.camel@jc-ulaptop> References: <1200044378.6337.8.camel@jc-ulaptop> Content-Type: text/plain; charset=utf-8 Organization: Novell, Inc. Date: Fri, 11 Jan 2008 15:33:21 -0500 Message-Id: <1200083601.2025.21.camel@tazmanian-devil.boston.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2 Content-Transfer-Encoding: 8bit Cc: evolution-patches@gnome.org Subject: Re: [evolution-patches] =?utf-8?q?Bug_329692_=E2=80=93_=09attachment_?= =?utf-8?q?size_in_composer_not=09shown_when_reopening?= X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 21:01:23 -0000 On Fri, 2008-01-11 at 10:39 +0100, Jean-Christophe BEGUE wrote: > Hello, > > This bug implies both evolution and evolution-data-server. I added a > function called > camel_mime_part_get_content_size () to > evolution-data-server/camel/mime-part.c and > used it in evolution/widget/misc/attachment.c. > > There's still a problem: the size displayed is bigger than the real > file size because > camel_data_wrapper_decode_to_stream () (used with an null stream to > get the size) returns > size of encoded data. How could i fix it? comment below > > This is my first patch, I hope i did everything right.(Please tell me > what i did wrong.) your patch looks pretty good :) > > Sorry for my english. > > Regards, > > Jean-Christophe BEGUE > > > > > > > differences > between files > attachment > (evolution329692.diff) > > > > > > > > differences > between files > attachment > (evolution-data-server-329692.diff) > > Index: camel/camel-mime-part.c > =================================================================== > --- camel/camel-mime-part.c (révision 8343) > +++ camel/camel-mime-part.c (copie de travail) > @@ -1060,3 +1060,25 @@ > medium->content = NULL; > } > } > + > +/** > + * camel_mime_part_get_content_size add a ':' at the end of 'camel_mime_part_get_content_size' so that the gtk-docs stuff can parse it > + * @mime_part: a #CamelMimePart object > + * > + * Function used to get the size of the mime part provided data. * * Returns the size of the MIME part's content in bytes. > + **/ > + > +ssize_t > +camel_mime_part_get_content_size (CamelMimePart *mime_part) > +{ > + ssize_t written; > + CamelStreamNull *nstream; > + CamelMedium *medium = CAMEL_MEDIUM (mime_part); > + CamelDataWrapper *dw = camel_medium_get_content_object > (medium); > + > + nstream = camel_stream_null_new (); > + written = camel_data_wrapper_write_to_stream (dw, nstream); in order to get the size of the decoded content, you'll want to use camel_data_wrapper_decode_to_stream() > + camel_object_unref (nstream); > + > + return written; > +} I'll make the corrections I mentioned above and commit the patch. Thanks! Jeff From sragavan@novell.com Fri Jan 11 21:34:35 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 0D02C750084 for ; Fri, 11 Jan 2008 21:34:35 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.417 X-Spam-Level: X-Spam-Status: No, score=-2.417 tagged_above=-999 required=2 tests=[AWL=-0.047, BAYES_00=-2.599, SARE_SUB_ENC_UTF8=0.152, TW_EJ=0.077] X-Amavis-OS-Fingerprint: Linux 2.4-2.6 (up: 4468 hrs), (distance 11, link: PIX, SMC, sometimes wireless), [137.65.250.26] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HxNlq4vJrD5L for ; Fri, 11 Jan 2008 21:34:29 +0000 (GMT) Received: from victor.provo.novell.com (victor.provo.novell.com [137.65.250.26]) by menubar.gnome.org (Postfix) with ESMTP id F068A75007C for ; Fri, 11 Jan 2008 21:34:28 +0000 (GMT) Received: from [192.168.0.3] (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP; Fri, 11 Jan 2008 14:34:18 -0700 From: Srinivasa Ragavan To: Jean-Christophe BEGUE In-Reply-To: <1200044378.6337.8.camel@jc-ulaptop> References: <1200044378.6337.8.camel@jc-ulaptop> Content-Type: text/plain Date: Sat, 12 Jan 2008 03:03:05 +0530 Message-Id: <1200087185.4810.37.camel@sragavan.blr.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit Cc: evolution-patches@gnome.org Subject: Re: [evolution-patches] =?utf-8?q?Bug_329692_=E2=80=93_=09attachment_?= =?utf-8?q?size_in_composer_not=09shown_when_reopening?= X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 21:34:35 -0000 Jean, Thanks for your patch. Fejj has already committed your patch (camel patch, slightly modified) to trunk. -Srini. On Fri, 2008-01-11 at 10:39 +0100, Jean-Christophe BEGUE wrote: > Hello, > > This bug implies both evolution and evolution-data-server. I added a > function called > camel_mime_part_get_content_size () to > evolution-data-server/camel/mime-part.c and > used it in evolution/widget/misc/attachment.c. > > There's still a problem: the size displayed is bigger than the real > file size because > camel_data_wrapper_decode_to_stream () (used with an null stream to > get the size) returns > size of encoded data. How could i fix it? > > This is my first patch, I hope i did everything right.(Please tell me > what i did wrong.) > > Sorry for my english. > > Regards, > > Jean-Christophe BEGUE > _______________________________________________ > Evolution-patches mailing list > Evolution-patches@gnome.org > http://mail.gnome.org/mailman/listinfo/evolution-patches From spam@pvanhoof.be Sat Jan 12 11:14:10 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id E523F750007 for ; Sat, 12 Jan 2008 11:14:09 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.413 X-Spam-Level: X-Spam-Status: No, score=-2.413 tagged_above=-999 required=2 tests=[AWL=-0.043, BAYES_00=-2.599, SARE_SUB_ENC_UTF8=0.152, TW_GT=0.077] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4289 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KOgePMzabtLe for ; Sat, 12 Jan 2008 11:14:04 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 6B07E75007E for ; Sat, 12 Jan 2008 11:14:03 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id 4785EECB0C; Sat, 12 Jan 2008 12:05:27 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xrpUhwCXO-j9; Sat, 12 Jan 2008 12:05:27 +0100 (CET) Received: from [192.168.1.113] (d54C0EE14.access.telenet.be [84.192.238.20]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 0333EECA04; Sat, 12 Jan 2008 12:05:26 +0100 (CET) From: Philip Van Hoof To: Jeffrey Stedfast In-Reply-To: <1200083601.2025.21.camel@tazmanian-devil.boston.novell.com> References: <1200044378.6337.8.camel@jc-ulaptop> <1200083601.2025.21.camel@tazmanian-devil.boston.novell.com> Content-Type: text/plain; charset=utf-8 Date: Sat, 12 Jan 2008 12:13:51 +0100 Message-Id: <1200136431.8380.0.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 8bit Cc: evolution-patches@gnome.org Subject: Re: [evolution-patches] =?utf-8?q?Bug_329692_=E2=80=93_=09attachment_?= =?utf-8?q?size_in_composer_not=09shown_when_reopening?= X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2008 11:14:10 -0000 FYI camel-mime-part.c: In function 'camel_mime_part_get_content_size': camel-mime-part.c:1090: warning: assignment from incompatible pointer type camel-mime-part.c:1091: warning: passing argument 2 of 'camel_data_wrapper_decode_to_stream' from incompatible pointer type On Fri, 2008-01-11 at 15:33 -0500, Jeffrey Stedfast wrote: > On Fri, 2008-01-11 at 10:39 +0100, Jean-Christophe BEGUE wrote: > > Hello, > > > > This bug implies both evolution and evolution-data-server. I added a > > function called > > camel_mime_part_get_content_size () to > > evolution-data-server/camel/mime-part.c and > > used it in evolution/widget/misc/attachment.c. > > > > There's still a problem: the size displayed is bigger than the real > > file size because > > camel_data_wrapper_decode_to_stream () (used with an null stream to > > get the size) returns > > size of encoded data. How could i fix it? > > > comment below > > > > > This is my first patch, I hope i did everything right.(Please tell me > > what i did wrong.) > > your patch looks pretty good :) > > > > Sorry for my english. > > > > Regards, > > > > Jean-Christophe BEGUE > > > > > > > > > > > > > > differences > > between files > > attachment > > (evolution329692.diff) > > > > > > > > > > > > > > > > differences > > between files > > attachment > > (evolution-data-server-329692.diff) > > > > Index: camel/camel-mime-part.c > > =================================================================== > > --- camel/camel-mime-part.c (révision 8343) > > +++ camel/camel-mime-part.c (copie de travail) > > @@ -1060,3 +1060,25 @@ > > medium->content = NULL; > > } > > } > > + > > +/** > > + * camel_mime_part_get_content_size > > add a ':' at the end of 'camel_mime_part_get_content_size' so that the > gtk-docs stuff can parse it > > > + * @mime_part: a #CamelMimePart object > > + * > > + * Function used to get the size of the mime part provided data. > > * > * Returns the size of the MIME part's content in bytes. > > > + **/ > > + > > +ssize_t > > +camel_mime_part_get_content_size (CamelMimePart *mime_part) > > +{ > > + ssize_t written; > > + CamelStreamNull *nstream; > > + CamelMedium *medium = CAMEL_MEDIUM (mime_part); > > + CamelDataWrapper *dw = camel_medium_get_content_object > > (medium); > > + > > + nstream = camel_stream_null_new (); > > + written = camel_data_wrapper_write_to_stream (dw, nstream); > > in order to get the size of the decoded content, you'll want to use > camel_data_wrapper_decode_to_stream() > > > + camel_object_unref (nstream); > > + > > + return written; > > +} > > I'll make the corrections I mentioned above and commit the patch. > Thanks! > > Jeff > > > _______________________________________________ > Evolution-patches mailing list > Evolution-patches@gnome.org > http://mail.gnome.org/mailman/listinfo/evolution-patches -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From sragavan@novell.com Sat Jan 12 15:35:57 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id E9AD77501AA for ; Sat, 12 Jan 2008 15:35:56 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.455 X-Spam-Level: X-Spam-Status: No, score=-2.455 tagged_above=-999 required=2 tests=[AWL=-0.008, BAYES_00=-2.599, SARE_SUB_ENC_UTF8=0.152] X-Amavis-OS-Fingerprint: Linux 2.4-2.6 (up: 4648 hrs), (distance 11, link: PIX, SMC, sometimes wireless), [137.65.250.26] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ym0bqgBgJ0bT for ; Sat, 12 Jan 2008 15:35:53 +0000 (GMT) Received: from victor.provo.novell.com (victor.provo.novell.com [137.65.250.26]) by menubar.gnome.org (Postfix) with ESMTP id 5C4A675014A for ; Sat, 12 Jan 2008 15:35:53 +0000 (GMT) Received: from [192.168.0.3] (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP; Sat, 12 Jan 2008 08:35:39 -0700 From: Srinivasa Ragavan To: Philip Van Hoof In-Reply-To: <1200136431.8380.0.camel@schtrumpf> References: <1200044378.6337.8.camel@jc-ulaptop> <1200083601.2025.21.camel@tazmanian-devil.boston.novell.com> <1200136431.8380.0.camel@schtrumpf> Content-Type: text/plain Date: Sat, 12 Jan 2008 21:04:28 +0530 Message-Id: <1200152068.8959.6.camel@sragavan.blr.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit Cc: evolution-patches@gnome.org Subject: Re: [evolution-patches] =?utf-8?q?Bug_329692_=E2=80=93_=09attachment_?= =?utf-8?q?size_in_composer_not=09shown_when_reopening?= X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2008 15:35:57 -0000 On Sat, 2008-01-12 at 12:13 +0100, Philip Van Hoof wrote: > FYI > > camel-mime-part.c: In function 'camel_mime_part_get_content_size': > camel-mime-part.c:1090: warning: assignment from incompatible pointer type > camel-mime-part.c:1091: warning: passing argument 2 of 'camel_data_wrapper_decode_to_stream' from incompatible pointer type Fixed now. -Srini From spam@pvanhoof.be Sat Jan 12 16:00:18 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 9FEDC75024D for ; Sat, 12 Jan 2008 16:00:18 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.451 X-Spam-Level: X-Spam-Status: No, score=-2.451 tagged_above=-999 required=2 tests=[AWL=-0.004, BAYES_00=-2.599, SARE_SUB_ENC_UTF8=0.152] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4294 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4+fhYxtHZTQn for ; Sat, 12 Jan 2008 16:00:13 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id DD7057501C1 for ; Sat, 12 Jan 2008 16:00:12 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id 7572C15D2FC; Sat, 12 Jan 2008 16:51:36 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ukd86tLBR41h; Sat, 12 Jan 2008 16:51:36 +0100 (CET) Received: from [192.168.1.113] (d54C0EE14.access.telenet.be [84.192.238.20]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 129BC15D29A; Sat, 12 Jan 2008 16:51:36 +0100 (CET) From: Philip Van Hoof To: Srinivasa Ragavan In-Reply-To: <1200152068.8959.6.camel@sragavan.blr.novell.com> References: <1200044378.6337.8.camel@jc-ulaptop> <1200083601.2025.21.camel@tazmanian-devil.boston.novell.com> <1200136431.8380.0.camel@schtrumpf> <1200152068.8959.6.camel@sragavan.blr.novell.com> Content-Type: text/plain Date: Sat, 12 Jan 2008 17:00:01 +0100 Message-Id: <1200153601.8380.6.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Cc: evolution-patches Subject: Re: [evolution-patches] =?utf-8?q?Bug_329692_=E2=80=93_=09attachment_?= =?utf-8?q?size_in_composer_not=09shown_when_reopening?= X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2008 16:00:18 -0000 On Sat, 2008-01-12 at 21:04 +0530, Srinivasa Ragavan wrote: > On Sat, 2008-01-12 at 12:13 +0100, Philip Van Hoof wrote: > > FYI > > > > camel-mime-part.c: In function 'camel_mime_part_get_content_size': > > camel-mime-part.c:1090: warning: assignment from incompatible pointer type > > camel-mime-part.c:1091: warning: passing argument 2 of 'camel_data_wrapper_decode_to_stream' from incompatible pointer type > > Fixed now. Thanks! And FYI is camel-lite merged with camel upstream once more. -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From spam@pvanhoof.be Mon Jan 14 01:21:47 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 499857500CE for ; Mon, 14 Jan 2008 01:21:47 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.527 X-Spam-Level: X-Spam-Status: No, score=-2.527 tagged_above=-999 required=2 tests=[AWL=0.072, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4327 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JRhZ6mrowWox for ; Mon, 14 Jan 2008 01:21:41 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 2D37D7500BB for ; Mon, 14 Jan 2008 01:21:41 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id AABFFEC8EA for ; Mon, 14 Jan 2008 02:13:01 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qNV++nQGF1+r for ; Mon, 14 Jan 2008 02:13:01 +0100 (CET) Received: from [192.168.1.113] (d54C0EE14.access.telenet.be [84.192.238.20]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 79A5CEC8E6 for ; Mon, 14 Jan 2008 02:13:01 +0100 (CET) From: Philip Van Hoof To: evolution-patches Content-Type: text/plain Date: Mon, 14 Jan 2008 02:21:30 +0100 Message-Id: <1200273690.8380.45.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Subject: [evolution-patches] PATCH: memleak fix in Maildir implementation X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 01:21:47 -0000 http://bugzilla.gnome.org/show_bug.cgi?id=509268 Please review -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From spam@pvanhoof.be Mon Jan 14 01:49:46 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 41AC475009C for ; Mon, 14 Jan 2008 01:49:46 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.527 X-Spam-Level: X-Spam-Status: No, score=-2.527 tagged_above=-999 required=2 tests=[AWL=0.072, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4328 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KCsluz+dQhll for ; Mon, 14 Jan 2008 01:49:40 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 1F87D7500DD for ; Mon, 14 Jan 2008 01:49:40 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id 79613EC82E; Mon, 14 Jan 2008 02:41:00 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Oel6NlyHotSC; Mon, 14 Jan 2008 02:41:00 +0100 (CET) Received: from [192.168.1.113] (d54C0EE14.access.telenet.be [84.192.238.20]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 0F914EC7D5; Mon, 14 Jan 2008 02:41:00 +0100 (CET) From: Philip Van Hoof To: evolution-patches Content-Type: text/plain Date: Mon, 14 Jan 2008 02:49:28 +0100 Message-Id: <1200275368.8380.54.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Subject: [evolution-patches] Memoryleak in CamelMultipart X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 01:49:46 -0000 http://bugzilla.gnome.org/show_bug.cgi?id=509270 Please review -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From kmaraas@broadpark.no Mon Jan 14 09:12:18 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 605D4750093 for ; Mon, 14 Jan 2008 09:12:16 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -3.103 X-Spam-Level: X-Spam-Status: No, score=-3.103 tagged_above=-999 required=2 tests=[AWL=0.496, BAYES_00=-2.599, L_P0F_Unix=-1] X-Amavis-OS-Fingerprint: Solaris 10 (beta) (NAT!), (distance 23, link: GPRS, T1, FreeS/WAN), [217.13.4.94] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qXVF2unb304G for ; Mon, 14 Jan 2008 09:12:04 +0000 (GMT) Received: from bgo1smout1.broadpark.no (bgo1smout1.broadpark.no [217.13.4.94]) by menubar.gnome.org (Postfix) with ESMTP id 87965750087 for ; Mon, 14 Jan 2008 09:11:57 +0000 (GMT) MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_/b9O6ezzI5aRJCPYRYxC/Q)" Received: from bgo1sminn1.broadpark.no ([217.13.4.93]) by bgo1smout1.broadpark.no (Sun Java(tm) System Messaging Server 6.3-3.01 (built Jul 12 2007; 32bit)) with ESMTP id <0JUM00FFIMV3GK80@bgo1smout1.broadpark.no> for evolution-patches@gnome.org; Mon, 14 Jan 2008 10:11:27 +0100 (CET) Received: from [10.0.0.151] ([80.203.243.165]) by bgo1sminn1.broadpark.no (Sun Java(tm) System Messaging Server 6.3-3.01 (built Jul 12 2007; 32bit)) with ESMTP id <0JUM00A5CMUTGYB6@bgo1sminn1.broadpark.no> for evolution-patches@gnome.org; Mon, 14 Jan 2008 10:11:27 +0100 (CET) From: Kjartan Maraas To: evolution-patches Date: Mon, 14 Jan 2008 10:11:14 +0100 Message-id: <1200301874.2844.2.camel@localhost.localdomain> X-Mailer: Evolution 2.21.4 (2.21.4-2.fc9) Subject: [evolution-patches] Fixes for missing punctuation in schemas X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 09:12:19 -0000 --Boundary_(ID_/b9O6ezzI5aRJCPYRYxC/Q) Content-type: text/plain Content-transfer-encoding: 7BIT Patch attached. Cheers Kjartan --Boundary_(ID_/b9O6ezzI5aRJCPYRYxC/Q) Content-type: text/x-patch; name=evolution-schemas-fixes.patch; charset=UTF-8 Content-transfer-encoding: 7BIT Content-disposition: attachment; filename=evolution-schemas-fixes.patch Index: shell/apps_evolution_shell.schemas.in =================================================================== --- shell/apps_evolution_shell.schemas.in (revisjon 34811) +++ shell/apps_evolution_shell.schemas.in (arbeidskopi) @@ -62,7 +62,7 @@ true Whether crash recovery should be done or not - Decides whether the crash recovery should be run or not + Decides whether the crash recovery should be run or not. @@ -238,7 +238,7 @@ list string - A string description of the current printer settings + A string description of the current printer settings. Index: plugins/attachment-reminder/apps-evolution-attachment-reminder.schemas.in =================================================================== --- plugins/attachment-reminder/apps-evolution-attachment-reminder.schemas.in (revisjon 34811) +++ plugins/attachment-reminder/apps-evolution-attachment-reminder.schemas.in (arbeidskopi) @@ -8,7 +8,7 @@ true Enable attachment reminder plugin - Enable attachment reminder plugin + Enable attachment reminder plugin. @@ -32,7 +32,7 @@ in a message body List of clues for the attachment reminder plugin to look for - in a message body + in a message body. Index: mail/em-filter-i18n.h =================================================================== --- mail/em-filter-i18n.h (revisjon 34811) +++ mail/em-filter-i18n.h (arbeidskopi) @@ -5,40 +5,29 @@ char *s = N_("Attachments"); char *s = N_("BCC"); char *s = N_("Beep"); +<<<<<<< .mine char *s = N_("CC"); char *s = N_("Completed On"); +======= +char *s = N_("CC"); +char *s = N_("Completed On"); char *s = N_("contains"); +>>>>>>> .r34811 char *s = N_("Copy to Folder"); char *s = N_("Date received"); char *s = N_("Date sent"); char *s = N_("Delete"); char *s = N_("Deleted"); -char *s = N_("does not contain"); -char *s = N_("does not end with"); -char *s = N_("does not exist"); -char *s = N_("does not return"); -char *s = N_("does not sound like"); -char *s = N_("does not start with"); char *s = N_("Do Not Exist"); char *s = N_("Draft"); -char *s = N_("ends with"); char *s = N_("Exist"); -char *s = N_("exists"); char *s = N_("Expression"); char *s = N_("Follow Up"); char *s = N_("Important"); -char *s = N_("is"); -char *s = N_("is after"); -char *s = N_("is before"); -char *s = N_("is Flagged"); -char *s = N_("is greater than"); -char *s = N_("is less than"); -char *s = N_("is not"); -char *s = N_("is not Flagged"); +char *s = N_("Junk Test"); char *s = N_("is not set"); char *s = N_("is set"); char *s = N_("Junk"); -char *s = N_("Junk Test"); char *s = N_("Label"); char *s = N_("Mailing list"); char *s = N_("Match All"); @@ -53,20 +42,39 @@ char *s = N_("Recipients"); char *s = N_("Regex Match"); char *s = N_("Replied to"); -char *s = N_("returns"); -char *s = N_("returns greater than"); -char *s = N_("returns less than"); char *s = N_("Run Program"); char *s = N_("Score"); char *s = N_("Sender"); char *s = N_("Set Label"); char *s = N_("Set Status"); char *s = N_("Size (kB)"); -char *s = N_("sounds like"); char *s = N_("Source Account"); char *s = N_("Specific header"); -char *s = N_("starts with"); char *s = N_("Status"); char *s = N_("Stop Processing"); char *s = N_("Subject"); char *s = N_("Unset Status"); +char *s = N_("contains"); +char *s = N_("does not contain"); +char *s = N_("does not end with"); +char *s = N_("does not exist"); +char *s = N_("does not return"); +char *s = N_("does not sound like"); +char *s = N_("does not start with"); +char *s = N_("ends with"); +char *s = N_("exists"); +char *s = N_("is Flagged"); +char *s = N_("is after"); +char *s = N_("is before"); +char *s = N_("is greater than"); +char *s = N_("is less than"); +char *s = N_("is not Flagged"); +char *s = N_("is not set"); +char *s = N_("is not"); +char *s = N_("is set"); +char *s = N_("is"); +char *s = N_("returns greater than"); +char *s = N_("returns less than"); +char *s = N_("returns"); +char *s = N_("sounds like"); +char *s = N_("starts with"); Index: mail/evolution-mail.schemas.in =================================================================== --- mail/evolution-mail.schemas.in (revisjon 34811) +++ mail/evolution-mail.schemas.in (arbeidskopi) @@ -165,7 +165,7 @@ 600 Composer Window default width - Default width of the Composer Window + Default width of the Composer Window. @@ -177,7 +177,7 @@ 500 Composer Window default height - Default height of the Composer Window + Default height of the Composer Window. @@ -276,9 +276,9 @@ Load images for HTML messages over http Load images for HTML messages over http(s). Possible values are: - 0 - Never load images off the net - 1 - Load images in messages from contacts - 2 - Always load images off the net + 0 - Never load images off the net. + 1 - Load images in messages from contacts. + 2 - Always load images off the net. @@ -380,7 +380,7 @@ Show the sender email in the messages column in the message list - Show the email of the sender in the messages composite column in the message list + Show the email of the sender in the messages composite column in the message list. @@ -392,9 +392,9 @@ int 1500 - Timeout for marking message as Seen + Timeout for marking message as seen - Timeout for marking message as Seen. + Timeout for marking message as seen. @@ -434,9 +434,9 @@ bool true - Enable Search Folders + Enable search folders - Enable Search Folders on startup. + Enable search folders on startup. @@ -507,7 +507,7 @@ Variable width font - The variable width font for mail display + The variable width font for mail display. @@ -521,7 +521,7 @@ Terminal font - The terminal font for mail display + The terminal font for mail display. @@ -535,7 +535,7 @@ Use custom fonts - Use custom fonts for displaying mail + Use custom fonts for displaying mail. @@ -549,7 +549,7 @@ Thread the message-list - Thread the message list. + Thread the message list. @@ -578,7 +578,7 @@ Allows evolution to display text part of limited size - Enable to render message text part of limited size. + Enable to render message text part of limited size. @@ -592,9 +592,9 @@ Text message part limit - This decides the max size of the text part that can be formatted under - evolution. The default is 4MB / 4096 KB and is specified interms of KB. - + This decides the max size of the text part that can be formatted under + evolution. The default is 4MB / 4096 KB and is specified interms of KB. + @@ -638,7 +638,7 @@ Default value for thread expand state This setting specifies whether the threads should be in expanded - or collapsed state by default. Evolution requires a restart + or collapsed state by default. Evolution requires a restart. @@ -669,7 +669,7 @@ 600 Message Window default width - Default width of the Message Window + Default width of the message window. @@ -681,7 +681,7 @@ 400 Message Window default height - Default height of the Message Window + Default height of the message window. @@ -695,7 +695,7 @@ 600 Subscribe dialog default width - Default width of the Subscribe dialog + Default width of the subscribe dialog. @@ -707,7 +707,7 @@ 400 Subscribe dialog default height - Default height of the Subscribe dialog + Default height of the subscribe dialog. @@ -1007,7 +1007,7 @@ Check incoming mail being junk - Run junk test on incoming mail + Run junk test on incoming mail. @@ -1093,7 +1093,7 @@ Use SpamAssassin daemon and client - Use SpamAssassin daemon and client (spamc/spamd) + Use SpamAssassin daemon and client (spamc/spamd). @@ -1153,7 +1153,7 @@ Save directory - Directory for saving mail component files + Directory for saving mail component files. @@ -1166,7 +1166,7 @@ Composer load/attach directory - Directory for loading/attaching files to composer + Directory for loading/attaching files to composer. --Boundary_(ID_/b9O6ezzI5aRJCPYRYxC/Q)-- From sragavan@novell.com Mon Jan 14 10:49:15 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 113827501BA for ; Mon, 14 Jan 2008 10:49:15 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.531 X-Spam-Level: X-Spam-Status: No, score=-2.531 tagged_above=-999 required=2 tests=[AWL=0.068, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.4-2.6 (up: 5079 hrs), (distance 11, link: PIX, SMC, sometimes wireless), [137.65.250.26] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nB9379iDMr2Z for ; Mon, 14 Jan 2008 10:49:10 +0000 (GMT) Received: from victor.provo.novell.com (victor.provo.novell.com [137.65.250.26]) by menubar.gnome.org (Postfix) with ESMTP id 719EA7500D1 for ; Mon, 14 Jan 2008 10:49:10 +0000 (GMT) Received: from [192.168.0.2] (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP; Mon, 14 Jan 2008 03:49:06 -0700 From: Srinivasa Ragavan To: Kjartan Maraas In-Reply-To: <1200301874.2844.2.camel@localhost.localdomain> References: <1200301874.2844.2.camel@localhost.localdomain> Content-Type: text/plain Date: Mon, 14 Jan 2008 16:16:53 +0530 Message-Id: <1200307613.17339.25.camel@sragavan.blr.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit Cc: evolution-patches Subject: Re: [evolution-patches] Fixes for missing punctuation in schemas X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 10:49:15 -0000 Retract your changes to mail/em-filter-i18n.h Otherwise, looks fine. commit to trunk and announce the string changes. -Srini. From spam@pvanhoof.be Mon Jan 14 11:05:09 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id B546F750171 for ; Mon, 14 Jan 2008 11:05:09 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.249 X-Spam-Level: X-Spam-Status: No, score=-2.249 tagged_above=-999 required=2 tests=[AWL=0.350, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4337 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yN33K75GPmcy for ; Mon, 14 Jan 2008 11:05:04 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 8AA6C7500D1 for ; Mon, 14 Jan 2008 11:05:04 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id 14BDEEC8F8 for ; Mon, 14 Jan 2008 11:56:24 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZRN88ZNx7pty for ; Mon, 14 Jan 2008 11:56:23 +0100 (CET) Received: from [127.0.0.1] (pvanhoof.freax.org [86.39.154.67]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 88FE1168417 for ; Mon, 14 Jan 2008 11:56:23 +0100 (CET) From: Philip Van Hoof To: evolution-patches Content-Type: text/plain Date: Mon, 14 Jan 2008 12:04:52 +0100 Message-Id: <1200308692.10942.12.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Subject: [evolution-patches] Patch: Memory leak fix in CamelImapFolder X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 11:05:09 -0000 http://bugzilla.gnome.org/show_bug.cgi?id=509332 Please review -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From kmaraas@broadpark.no Mon Jan 14 11:35:23 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 413CE75017A for ; Mon, 14 Jan 2008 11:35:23 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -3.104 X-Spam-Level: X-Spam-Status: No, score=-3.104 tagged_above=-999 required=2 tests=[AWL=0.495, BAYES_00=-2.599, L_P0F_Unix=-1] X-Amavis-OS-Fingerprint: Solaris 10 (beta) (NAT!), (distance 23, link: GPRS, T1, FreeS/WAN), [217.13.4.94] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NFikNsvzwpX5 for ; Mon, 14 Jan 2008 11:35:18 +0000 (GMT) Received: from bgo1smout1.broadpark.no (bgo1smout1.broadpark.no [217.13.4.94]) by menubar.gnome.org (Postfix) with ESMTP id D1FFA750087 for ; Mon, 14 Jan 2008 11:35:17 +0000 (GMT) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain Received: from bgo1sminn1.broadpark.no ([217.13.4.93]) by bgo1smout1.broadpark.no (Sun Java(tm) System Messaging Server 6.3-3.01 (built Jul 12 2007; 32bit)) with ESMTP id <0JUM00HT1TIS4I70@bgo1smout1.broadpark.no> for evolution-patches@gnome.org; Mon, 14 Jan 2008 12:35:16 +0100 (CET) Received: from [10.0.0.151] ([80.203.243.165]) by bgo1sminn1.broadpark.no (Sun Java(tm) System Messaging Server 6.3-3.01 (built Jul 12 2007; 32bit)) with ESMTP id <0JUM000X3TIQBJ46@bgo1sminn1.broadpark.no> for evolution-patches@gnome.org; Mon, 14 Jan 2008 12:35:16 +0100 (CET) From: Kjartan Maraas To: Srinivasa Ragavan In-reply-to: <1200307613.17339.25.camel@sragavan.blr.novell.com> References: <1200301874.2844.2.camel@localhost.localdomain> <1200307613.17339.25.camel@sragavan.blr.novell.com> Date: Mon, 14 Jan 2008 12:35:13 +0100 Message-id: <1200310513.2844.4.camel@localhost.localdomain> X-Mailer: Evolution 2.21.4 (2.21.4-2.fc9) Cc: evolution-patches Subject: Re: [evolution-patches] Fixes for missing punctuation in schemas X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 11:35:23 -0000 ma., 14.01.2008 kl. 16.16 +0530, skrev Srinivasa Ragavan: > Retract your changes to mail/em-filter-i18n.h > > Otherwise, looks fine. commit to trunk and announce the string changes. > Done. Cheers Kjartan From spam@pvanhoof.be Mon Jan 14 13:40:08 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id C431F7501AE; Mon, 14 Jan 2008 13:40:08 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.269 X-Spam-Level: X-Spam-Status: No, score=-2.269 tagged_above=-999 required=2 tests=[AWL=0.330, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4339 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TWhs0+aM3xHn; Mon, 14 Jan 2008 13:40:00 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 8744375004D; Mon, 14 Jan 2008 13:39:55 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id A6C9DEC8DB; Mon, 14 Jan 2008 14:31:14 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WWHjTBNdeuW0; Mon, 14 Jan 2008 14:31:14 +0100 (CET) Received: from [127.0.0.1] (pvanhoof.freax.org [86.39.154.67]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id E4A8315D319; Mon, 14 Jan 2008 14:31:12 +0100 (CET) From: Philip Van Hoof To: Evolution Hackers , evolution-patches In-Reply-To: <1200317591.10942.18.camel@schtrumpf> References: <1200271623.8380.43.camel@schtrumpf> <1200274117.8380.53.camel@schtrumpf> <1200317591.10942.18.camel@schtrumpf> Content-Type: text/plain Date: Mon, 14 Jan 2008 14:39:41 +0100 Message-Id: <1200317981.10942.19.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Cc: tinymail-devel-list Subject: [evolution-patches] Patch: memoryleak fix in CamelOperation. Was: [Evolution-hackers] Possible memory leak X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 13:40:09 -0000 Please review http://bugzilla.gnome.org/show_bug.cgi?id=509370 On Mon, 2008-01-14 at 14:33 +0100, Philip Van Hoof wrote: > I think I've found the leak ... > > g_slist_remove_link: > -------------------- > Removes an element from a GSList, without freeing the element. The > removed element's next link is set to NULL, so that it becomes a > self-contained list with one element. > > Notice the "without freeing the element" > > Yet > > void > camel_operation_end (CamelOperation *cc) > { > ... > > g_free(s); > cc->status_stack = g_slist_remove_link(cc->status_stack, > cc->status_stack); > UNLOCK(); > > if (msg) { > cc->status(cc, msg, sofar, oftotal, cc->status_data); > g_free(msg); > } > } > > I think this needs to be something like this: > > GSList *item = cc->status_stack; > cc->status_stack = g_slist_remove_link(cc->status_stack, item); > g_slist_free (item); > > > Can somebody with GSList know-how acknowledge this? > > > > On Mon, 2008-01-14 at 02:28 +0100, Philip Van Hoof wrote: > > On Mon, 2008-01-14 at 01:47 +0100, Philip Van Hoof wrote: > > > > > I have this memory analysis tool that I'm willing to believe that tells > > > me this line in camel-folder.c causes 381 times a leaked allocation of > > > in total 5.95 kb. (I opened one folder of 1000 items). It seems to be > > > the g_slice_alloc (which does a malloc since I disabled gslice) of the > > > g_hash_node_new. > > > > I found it, this was my own mistake in camel-lite's adaptations. > > > > I have found another leak in camel-operation.c: > > > > The cc->status_stack = g_slist_prepend(cc->status_stack, s); in > > camel_operation_start seems to be leaked each time it's called. > > > > I have 23 calls leaking 184 bytes. Various callers of > > camel_operation_start (all of them, it seems) seem to create this leak. > > > > My version of camel-operation.c adds two fields (a total and a current > > position in stead of a percentage, because my requirements where to give > > accurate to-the-byte progress info, not rounded percentages). Those > > changes are closely reviewed once more and don't seem to be causing this > > leak. > > > > ps. I attached the differences that I have. I basically replaced "pc" > > with a "sofar" and a "oftotal". > > > > > > _______________________________________________ > > Evolution-hackers mailing list > > Evolution-hackers@gnome.org > > http://mail.gnome.org/mailman/listinfo/evolution-hackers -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From fejj@novell.com Mon Jan 14 14:03:59 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id F2E927500C8 for ; Mon, 14 Jan 2008 14:03:58 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -0.31 X-Spam-Level: X-Spam-Status: No, score=-0.31 tagged_above=-999 required=2 tests=[BAYES_05=-1.11, L_P0F_UNKN=0.8] X-Amavis-OS-Fingerprint: UNKNOWN [S4:53:1:60:M1460,N,N,N,N,N,N,N,N,N,N,N,N,N,N:!:?:?], (link: ethernet/modem), [76.96.30.17] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YHytRybVeTdK for ; Mon, 14 Jan 2008 14:03:52 +0000 (GMT) Received: from QMTA10.emeryville.ca.mail.comcast.net (qmta10.emeryville.ca.mail.comcast.net [76.96.30.17]) by menubar.gnome.org (Postfix) with ESMTP id DD1087502B0 for ; Mon, 14 Jan 2008 14:03:51 +0000 (GMT) Received: from OMTA03.emeryville.ca.mail.comcast.net ([76.96.30.27]) by QMTA10.emeryville.ca.mail.comcast.net with comcast id d1kj1Y00A0b6N64AA01A00; Mon, 14 Jan 2008 14:03:45 +0000 Received: from [192.168.1.101] ([75.69.164.99]) by OMTA03.emeryville.ca.mail.comcast.net with comcast id d23T1Y00928zPtn8P00000; Mon, 14 Jan 2008 14:03:29 +0000 X-Authority-Analysis: v=1.0 c=1 a=I9m1jLbx6ikA:10 a=aiIX5UjjAAAA:8 a=DarNRNVbAlPBMxWoU8kA:9 a=2ydC8RQZE5dYFtjYLku1XwZMi4EA:4 a=c7PO8omglNEA:10 From: Jeffrey Stedfast To: Philip Van Hoof In-Reply-To: <1200273690.8380.45.camel@schtrumpf> References: <1200273690.8380.45.camel@schtrumpf> Content-Type: text/plain Organization: Novell, Inc. Date: Mon, 14 Jan 2008 09:03:40 -0500 Message-Id: <1200319420.5972.307.camel@serenity> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Cc: evolution-patches Subject: Re: [evolution-patches] PATCH: memleak fix in Maildir implementation X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 14:03:59 -0000 just had a look-see in the code and this patch looks correct Jeff On Mon, 2008-01-14 at 02:21 +0100, Philip Van Hoof wrote: > http://bugzilla.gnome.org/show_bug.cgi?id=509268 > > Please review > From spam@pvanhoof.be Mon Jan 14 14:30:42 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 4EE80750244 for ; Mon, 14 Jan 2008 14:30:42 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.279 X-Spam-Level: X-Spam-Status: No, score=-2.279 tagged_above=-999 required=2 tests=[AWL=0.320, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4340 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NByeGCdIT4Is for ; Mon, 14 Jan 2008 14:30:35 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 91AB5750414 for ; Mon, 14 Jan 2008 14:29:51 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id C142015D30E; Mon, 14 Jan 2008 15:21:10 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KsRLszIywNKw; Mon, 14 Jan 2008 15:21:10 +0100 (CET) Received: from [127.0.0.1] (pvanhoof.freax.org [86.39.154.67]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 65355EC8FE; Mon, 14 Jan 2008 15:21:08 +0100 (CET) From: Philip Van Hoof To: Jeffrey Stedfast In-Reply-To: <1200319420.5972.307.camel@serenity> References: <1200273690.8380.45.camel@schtrumpf> <1200319420.5972.307.camel@serenity> Content-Type: text/plain Date: Mon, 14 Jan 2008 15:29:37 +0100 Message-Id: <1200320977.19844.0.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Cc: evolution-patches Subject: Re: [evolution-patches] PATCH: memleak fix in Maildir implementation X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 14:30:42 -0000 On Mon, 2008-01-14 at 09:03 -0500, Jeffrey Stedfast wrote: > just had a look-see in the code and this patch looks correct > > Jeff > > On Mon, 2008-01-14 at 02:21 +0100, Philip Van Hoof wrote: > > http://bugzilla.gnome.org/show_bug.cgi?id=509268 > > > > Please review Committed -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From spam@pvanhoof.be Mon Jan 14 14:33:40 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id EBD8D7501E1 for ; Mon, 14 Jan 2008 14:33:39 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.288 X-Spam-Level: X-Spam-Status: No, score=-2.288 tagged_above=-999 required=2 tests=[AWL=0.312, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4340 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D3P3MhxLka2j for ; Mon, 14 Jan 2008 14:33:33 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id A54F675014C for ; Mon, 14 Jan 2008 14:33:33 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id B16C015D30E for ; Mon, 14 Jan 2008 15:24:52 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jgqM+zUYcT5k for ; Mon, 14 Jan 2008 15:24:52 +0100 (CET) Received: from [127.0.0.1] (pvanhoof.freax.org [86.39.154.67]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 171AD15D30D for ; Mon, 14 Jan 2008 15:24:51 +0100 (CET) From: Philip Van Hoof To: evolution-patches In-Reply-To: <1200308692.10942.12.camel@schtrumpf> References: <1200308692.10942.12.camel@schtrumpf> Content-Type: text/plain Date: Mon, 14 Jan 2008 15:33:20 +0100 Message-Id: <1200321200.19844.2.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Subject: Re: [evolution-patches] Patch: Memory leak fix in CamelImapFolder X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 14:33:40 -0000 On Mon, 2008-01-14 at 12:04 +0100, Philip Van Hoof wrote: > http://bugzilla.gnome.org/show_bug.cgi?id=509332 > > Please review Committed after approval from Matthew in the bug report. -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From spam@pvanhoof.be Mon Jan 14 15:17:48 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 1581F750151 for ; Mon, 14 Jan 2008 15:17:48 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.296 X-Spam-Level: X-Spam-Status: No, score=-2.296 tagged_above=-999 required=2 tests=[AWL=0.303, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4341 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0tJ9+y1bc8nK for ; Mon, 14 Jan 2008 15:17:41 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id ECD44750475 for ; Mon, 14 Jan 2008 15:17:40 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id 069FEEC8FE for ; Mon, 14 Jan 2008 16:09:00 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aVZ6fnK1ZyHY for ; Mon, 14 Jan 2008 16:08:59 +0100 (CET) Received: from [127.0.0.1] (pvanhoof.freax.org [86.39.154.67]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 536C7EC8D9 for ; Mon, 14 Jan 2008 16:08:59 +0100 (CET) From: Philip Van Hoof To: evolution-patches In-Reply-To: <1200275368.8380.54.camel@schtrumpf> References: <1200275368.8380.54.camel@schtrumpf> Content-Type: text/plain Date: Mon, 14 Jan 2008 16:17:28 +0100 Message-Id: <1200323848.19844.4.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Subject: Re: [evolution-patches] Memoryleak in CamelMultipart X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 15:17:49 -0000 On Mon, 2008-01-14 at 02:49 +0100, Philip Van Hoof wrote: > http://bugzilla.gnome.org/show_bug.cgi?id=509270 > > Please review Committed after Matthew's approval in the bug report -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From spam@pvanhoof.be Wed Jan 16 19:17:52 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 088887501ED for ; Wed, 16 Jan 2008 19:17:52 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.527 X-Spam-Level: X-Spam-Status: No, score=-2.527 tagged_above=-999 required=2 tests=[AWL=0.072, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4393 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tC3sQ1neW1Al for ; Wed, 16 Jan 2008 19:17:41 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id CDB1B750200 for ; Wed, 16 Jan 2008 19:17:40 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id E0DA6EC873 for ; Wed, 16 Jan 2008 20:08:53 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6xzr04QTAuPZ for ; Wed, 16 Jan 2008 20:08:53 +0100 (CET) Received: from [192.168.1.113] (d54C0EE14.access.telenet.be [84.192.238.20]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 9D041EC835 for ; Wed, 16 Jan 2008 20:08:53 +0100 (CET) From: Philip Van Hoof To: evolution-patches Content-Type: multipart/mixed; boundary="=-zvIt6Jexnig2A59q5onH" Date: Wed, 16 Jan 2008 20:17:28 +0100 Message-Id: <1200511048.8380.34.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Subject: [evolution-patches] PATCH: Small bug fix for camel-mime-utils.c X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2008 19:17:52 -0000 --=-zvIt6Jexnig2A59q5onH Content-Type: text/plain Content-Transfer-Encoding: 7bit Please review -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be --=-zvIt6Jexnig2A59q5onH Content-Disposition: attachment; filename=camel-mime-utils.diff Content-Type: text/x-patch; name=camel-mime-utils.diff; charset=UTF-8 Content-Transfer-Encoding: 8bit Index: camel-mime-utils.c =================================================================== --- camel-mime-utils.c (revision 8380) +++ camel-mime-utils.c (working copy) @@ -920,7 +920,7 @@ charsets[i++] = default_charset; locale_charset = e_iconv_locale_charset (); - if (g_ascii_strcasecmp (locale_charset, "UTF-8") != 0) + if (locale_charset && g_ascii_strcasecmp (locale_charset, "UTF-8") != 0) charsets[i++] = locale_charset; min = len; Index: ChangeLog =================================================================== --- ChangeLog (revision 8380) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2008-01-18 Philip Van Hoof + + * camel-mime-utils.c: Small bug fix + 2008-01-16 Øystein Gisnås ** Fix for bug #300098 --=-zvIt6Jexnig2A59q5onH-- From spam@pvanhoof.be Wed Jan 16 19:54:32 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 46BF07500CB for ; Wed, 16 Jan 2008 19:54:32 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.527 X-Spam-Level: X-Spam-Status: No, score=-2.527 tagged_above=-999 required=2 tests=[AWL=0.072, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6, seldom 2.4 (older, 4) (up: 4394 hrs), (distance 13, link: ethernet/modem), [86.39.154.66] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fyXyXMgmVppB for ; Wed, 16 Jan 2008 19:54:26 +0000 (GMT) Received: from mail.freax.org (mail.freax.org [86.39.154.66]) by menubar.gnome.org (Postfix) with ESMTP id 0173A75018E for ; Wed, 16 Jan 2008 19:54:25 +0000 (GMT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.freax.org (Postfix) with ESMTP id A2215EC9AE for ; Wed, 16 Jan 2008 20:45:39 +0100 (CET) Received: from mail.freax.org ([127.0.0.1]) by localhost (mail.freax.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lDZWg6u+jhmD for ; Wed, 16 Jan 2008 20:45:39 +0100 (CET) Received: from [192.168.1.113] (d54C0EE14.access.telenet.be [84.192.238.20]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.freax.org (Postfix) with ESMTP id 696BB168276 for ; Wed, 16 Jan 2008 20:45:39 +0100 (CET) From: Philip Van Hoof To: evolution-patches In-Reply-To: <1200511048.8380.34.camel@schtrumpf> References: <1200511048.8380.34.camel@schtrumpf> Content-Type: text/plain Date: Wed, 16 Jan 2008 20:54:14 +0100 Message-Id: <1200513254.8380.37.camel@schtrumpf> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Subject: Re: [evolution-patches] PATCH: Small bug fix for camel-mime-utils.c X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2008 19:54:32 -0000 On Wed, 2008-01-16 at 20:17 +0100, Philip Van Hoof wrote: > Please review Hmm the patch might not be right as the check is != 0 in stead of == 0. Anyway, the problem here is that local_charset can be NULL and that the strcmp would assert() on the first parameter being NULL. -- Philip Van Hoof, freelance software developer home: me at pvanhoof dot be gnome: pvanhoof at gnome dot org http://pvanhoof.be/blog http://codeminded.be From fejj@novell.com Wed Jan 16 20:20:46 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 6E2B2750136 for ; Wed, 16 Jan 2008 20:20:46 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -1.11 X-Spam-Level: X-Spam-Status: No, score=-1.11 tagged_above=-999 required=2 tests=[BAYES_05=-1.11] X-Amavis-OS-Fingerprint: Linux 2.4-2.6 (up: 5656 hrs), (distance 11, link: PIX, SMC, sometimes wireless), [137.65.250.26] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id obcJZ02bDarf for ; Wed, 16 Jan 2008 20:20:42 +0000 (GMT) Received: from victor.provo.novell.com (victor.provo.novell.com [137.65.250.26]) by menubar.gnome.org (Postfix) with ESMTP id 728507500CB for ; Wed, 16 Jan 2008 20:20:42 +0000 (GMT) Received: from [164.99.120.160] (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP (TLS encrypted); Wed, 16 Jan 2008 13:20:41 -0700 From: Jeffrey Stedfast To: Philip Van Hoof In-Reply-To: <1200513254.8380.37.camel@schtrumpf> References: <1200511048.8380.34.camel@schtrumpf> <1200513254.8380.37.camel@schtrumpf> Content-Type: text/plain Organization: Novell, Inc. Date: Wed, 16 Jan 2008 15:11:09 -0500 Message-Id: <1200514269.2025.115.camel@tazmanian-devil.boston.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2 Content-Transfer-Encoding: 7bit Cc: evolution-patches Subject: Re: [evolution-patches] PATCH: Small bug fix for camel-mime-utils.c X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2008 20:20:46 -0000 No, I think your first patch had it right. Jeff On Wed, 2008-01-16 at 20:54 +0100, Philip Van Hoof wrote: > On Wed, 2008-01-16 at 20:17 +0100, Philip Van Hoof wrote: > > Please review > > Hmm the patch might not be right as the check is != 0 in stead of == 0. > > Anyway, the problem here is that local_charset can be NULL and that the > strcmp would assert() on the first parameter being NULL. > > From begue.jc@gmail.com Sat Jan 19 16:22:42 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id A4F967501E6 for ; Sat, 19 Jan 2008 16:22:42 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.025 X-Spam-Level: X-Spam-Status: No, score=-2.025 tagged_above=-999 required=2 tests=[BAYES_00=-2.599, HTML_40_50=0.496, HTML_MESSAGE=0.001, TW_GT=0.077] X-Amavis-OS-Fingerprint: Linux 2.6 (newer, 2) (firewall!) (up: 10412 hrs), (distance 17, link: (Google 2)), [72.14.220.153] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YhNRV44RzKCY for ; Sat, 19 Jan 2008 16:22:39 +0000 (GMT) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.153]) by menubar.gnome.org (Postfix) with ESMTP id EAB8275008B for ; Sat, 19 Jan 2008 16:22:38 +0000 (GMT) Received: by fg-out-1718.google.com with SMTP id d23so1459080fga.33 for ; Sat, 19 Jan 2008 08:22:37 -0800 (PST) Received: by 10.86.91.12 with SMTP id o12mr4355497fgb.62.1200759756968; Sat, 19 Jan 2008 08:22:36 -0800 (PST) Received: from ?192.168.1.12? ( [81.251.107.4]) by mx.google.com with ESMTPS id e11sm5803602fga.5.2008.01.19.08.22.35 (version=SSLv3 cipher=RC4-MD5); Sat, 19 Jan 2008 08:22:36 -0800 (PST) From: Jean-Christophe BEGUE To: "[evolution-patches]" Content-Type: multipart/mixed; boundary="=-ZRQT8QhDewuEKL3GTz/A" Date: Sat, 19 Jan 2008 17:22:05 +0100 Message-Id: <1200759725.28846.2.camel@jc-ulaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.21.90 Subject: [evolution-patches] status bar resizing X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jan 2008 16:22:42 -0000 --=-ZRQT8QhDewuEKL3GTz/A Content-Type: multipart/alternative; boundary="=-s4f3CY0QFH0QWMuVmIHz" --=-s4f3CY0QFH0QWMuVmIHz Content-Type: text/plain Content-Transfer-Encoding: 7bit Hello, The status bar size is changing when it displays a menu description (when the cursor is over menu entries). It makes move the whole bottom of window. Here's a patch to avoid that (it modifies shell/e-shell-window.c). Jean-Christophe BEGUE --=-s4f3CY0QFH0QWMuVmIHz Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit Hello,

The status bar size is changing when it displays a menu description (when the cursor is over menu entries). It makes move the whole bottom of window.

Here's a patch to avoid that (it modifies shell/e-shell-window.c).

Jean-Christophe BEGUE --=-s4f3CY0QFH0QWMuVmIHz-- --=-ZRQT8QhDewuEKL3GTz/A Content-Disposition: attachment; filename=status_bar_size.diff Content-Type: text/x-patch; name=status_bar_size.diff; charset=UTF-8 Content-Transfer-Encoding: 8bit Index: shell/e-shell-window.c =================================================================== --- shell/e-shell-window.c (révision 34836) +++ shell/e-shell-window.c (copie de travail) @@ -45,6 +45,7 @@ #include #include #include +#include #include #include @@ -603,10 +604,16 @@ EShellWindowPrivate *priv; BonoboUIEngine *ui_engine; GConfClient *gconf_client; + gint height; priv = window->priv; priv->status_bar = gtk_hbox_new (FALSE, 2); + + /* Make the status bar as large as the task bar. */ + gtk_icon_size_lookup (GTK_ICON_SIZE_MENU, NULL, &height); + gtk_widget_set_size_request (GTK_WIDGET (priv->status_bar), -1, height * 2); + gconf_client = gconf_client_get_default (); if(gconf_client_get_bool (gconf_client,"/apps/evolution/shell/view_defaults/statusbar_visible",NULL)) gtk_widget_show (priv->status_bar); --=-ZRQT8QhDewuEKL3GTz/A-- From mbarnes@redhat.com Sun Jan 20 04:21:11 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 933CB750087 for ; Sun, 20 Jan 2008 04:21:11 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.553 X-Spam-Level: X-Spam-Status: No, score=-2.553 tagged_above=-999 required=2 tests=[AWL=0.046, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.6 (newer, 3) (NAT!) (up: 8622 hrs), (distance 10, link: GPRS, T1, FreeS/WAN), [66.187.233.31] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35qq6y005047 for ; Sun, 20 Jan 2008 04:21:04 +0000 (GMT) Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31]) by menubar.gnome.org (Postfix) with ESMTP id 1DB3B75000B for ; Sun, 20 Jan 2008 04:21:03 +0000 (GMT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m0K4L28l016087 for ; Sat, 19 Jan 2008 23:21:02 -0500 Received: from mail.boston.redhat.com (mail.boston.redhat.com [172.16.76.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m0K4L26F004312 for ; Sat, 19 Jan 2008 23:21:02 -0500 Received: from [10.13.248.20] (vpn-248-20.boston.redhat.com [10.13.248.20]) by mail.boston.redhat.com (8.13.1/8.13.1) with ESMTP id m0K4L1Dr013678 for ; Sat, 19 Jan 2008 23:21:01 -0500 From: Matthew Barnes To: evolution-patches@gnome.org In-Reply-To: <1200759725.28846.2.camel@jc-ulaptop> References: <1200759725.28846.2.camel@jc-ulaptop> Content-Type: text/plain Date: Sat, 19 Jan 2008 23:21:00 -0500 Message-Id: <1200802860.18576.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.21.90 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Subject: Re: [evolution-patches] status bar resizing X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jan 2008 04:21:11 -0000 On Sat, 2008-01-19 at 17:22 +0100, Jean-Christophe BEGUE wrote: > The status bar size is changing when it displays a menu description > (when the cursor is over menu entries). It makes move the whole bottom > of window. > > Here's a patch to avoid that (it modifies shell/e-shell-window.c). Thanks for the patch. Can you please add it to bug #509509 so we can track it more easily? http://bugzilla.gnome.org/show_bug.cgi?id=509509 Matthew Barnes From abhijeetasawant@gmail.com Mon Jan 28 13:42:15 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id 976CD750075 for ; Mon, 28 Jan 2008 13:42:15 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: 0.002 X-Spam-Level: X-Spam-Status: No, score=0.002 tagged_above=-999 required=2 tests=[BAYES_50=0.001, HTML_MESSAGE=0.001] X-Amavis-OS-Fingerprint: Linux 2.6 (newer, 2) (firewall!) (up: 3777 hrs), (distance 14, link: (Google 2)), [66.249.82.235] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o2DIE-wowDDL for ; Mon, 28 Jan 2008 13:42:13 +0000 (GMT) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.235]) by menubar.gnome.org (Postfix) with ESMTP id 965117500B4 for ; Mon, 28 Jan 2008 13:42:13 +0000 (GMT) Received: by wx-out-0506.google.com with SMTP id h26so1014833wxd.9 for ; Mon, 28 Jan 2008 05:42:12 -0800 (PST) Received: by 10.142.229.4 with SMTP id b4mr2295466wfh.125.1201527731197; Mon, 28 Jan 2008 05:42:11 -0800 (PST) Received: by 10.142.99.17 with HTTP; Mon, 28 Jan 2008 05:42:11 -0800 (PST) Message-ID: <7e59e6a40801280542x72032830m51a0622fd3f6618e@mail.gmail.com> Date: Mon, 28 Jan 2008 19:12:11 +0530 From: "Abhijeet Sawant" To: evolution-patches@gnome.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_10485_16002515.1201527731187" X-Mailman-Approved-At: Mon, 28 Jan 2008 14:02:21 +0000 Subject: [evolution-patches] want patch for e_vcard_to_string_vcard_21 (e-vcard.c) X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 13:42:15 -0000 ------=_Part_10485_16002515.1201527731187 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline hi, I am working on eds-dbus. We need a patch for e_vcard_to_string_vcard_21 function. Please Reply -- Thanks & Regards, Abhijeet A Sawant. ------=_Part_10485_16002515.1201527731187 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline hi,
I am working on eds-dbus.
We need a patch for e_vcard_to_string_vcard_21 function.
Please Reply

--
Thanks & Regards,
Abhijeet A Sawant. ------=_Part_10485_16002515.1201527731187-- From sragavan@novell.com Mon Jan 28 14:31:06 2008 Return-Path: X-Original-To: evolution-patches@gnome.org Delivered-To: evolution-patches@gnome.org Received: from localhost (localhost.localdomain [127.0.0.1]) by menubar.gnome.org (Postfix) with ESMTP id CB3B2750065 for ; Mon, 28 Jan 2008 14:31:06 +0000 (GMT) X-Virus-Scanned: by amavisd-new at gnome.org X-Spam-Flag: NO X-Spam-Score: -2.527 X-Spam-Level: X-Spam-Status: No, score=-2.527 tagged_above=-999 required=2 tests=[AWL=0.072, BAYES_00=-2.599] X-Amavis-OS-Fingerprint: Linux 2.4-2.6 (up: 8477 hrs), (distance 11, link: PIX, SMC, sometimes wireless), [137.65.250.26] Received: from menubar.gnome.org ([127.0.0.1]) by localhost (menubar.gnome.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oI2swiqP+9dK for ; Mon, 28 Jan 2008 14:31:03 +0000 (GMT) Received: from victor.provo.novell.com (victor.provo.novell.com [137.65.250.26]) by menubar.gnome.org (Postfix) with ESMTP id 105AC750215 for ; Mon, 28 Jan 2008 14:31:02 +0000 (GMT) Received: from [192.168.0.3] (prv-ext-foundry1.gns.novell.com [137.65.251.240]) by victor.provo.novell.com with ESMTP; Mon, 28 Jan 2008 07:30:52 -0700 From: Srinivasa Ragavan To: Abhijeet Sawant In-Reply-To: <7e59e6a40801280542x72032830m51a0622fd3f6618e@mail.gmail.com> References: <7e59e6a40801280542x72032830m51a0622fd3f6618e@mail.gmail.com> Content-Type: text/plain Date: Mon, 28 Jan 2008 20:03:24 +0530 Message-Id: <1201530804.4106.13.camel@sragavan.blr.novell.com> Mime-Version: 1.0 X-Mailer: Evolution 2.21.90 Content-Transfer-Encoding: 7bit Cc: evolution-patches@gnome.org Subject: Re: [evolution-patches] want patch for e_vcard_to_string_vcard_21 (e-vcard.c) X-BeenThere: evolution-patches@gnome.org X-Mailman-Version: 2.1.8 Precedence: list List-Id: list for patches against evolution and evolution-data-server List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 14:31:07 -0000 Hi, On Mon, 2008-01-28 at 19:12 +0530, Abhijeet Sawant wrote: > hi, > I am working on eds-dbus. > We need a patch for e_vcard_to_string_vcard_21 function. What patch for what? -Srini