Re: [evolution-patches] Bug 46351, Calendar:Accesskey for Time_z_one doesn't work

[Carl sun <carl sun sun com>]

Hi, JP Rosevear,

     I am explaining why I add get_private_buttons accessor method  in my submitted patch:
     As you known, "button"  is defined in the ETimezoneEntryPrivate, a private attribute of ETimezoneEntry.  The function  e_timezone_entry_mnemonic_activate (GtkWidget *widget,     gboolean  group_cycling) doesn't belong to member method of ETimezoneEntry. According to encapsulation and accessive mechanism of OO,  so I add the member method "get_private_buttons" to access the private attribute of ETimezoneEntry.

    Of course, I have tried deleting this accessor method, that is okay. but I don't think this way works better for the sake of  the complexity of access and breaking the encapsulation mechanism.
   
    It's up to you which way we can take. If the latter is much prefer, I will send the new version of patch to you. Waiting for your reply! 
 
    Regards,

 Carl Sun

On Mon, 2003-11-24 at 13:19, JP Rosevear wrote:
> On Sun, 2003-11-16 at 23:33, Carl sun wrote:
> > hi, JP Rosevear
> >  
> >    I am writing to tell you that I have fixed the bug 46351, which
> > occurs in evolution 1.4.4, and the Synopsis is "Accesskey for Time
> > _z_one doesn't work".
> > 
> >   The major modification focus on the file "e-timezone-entry.c".As to
> > the more detailed modification, please refer to diff files in the
> > attachment.
> > 
> >   It is noted that the expected correct result of the accesskey should
> > be "focus on the '...' button",rather than "focus on the text entry".
> > please check it.
>
> We are you adding the get_private_buttons accessor method?
>
> -JP